Repository navigation
[15.0][MIG] Migration of queue_job_subscribe - #395
Closed
lembregtse wants to merge 2 commits into
Closed
lembregtse wants to merge 2 commits into
lembregtse wants to merge 2 commits into
Conversation
2 of 10 tasks
lembregtse
changed the title
|
@lembregtse "installable": False? Is this on purpose? |
|
Hi @lembregtse, Is this abandoned? |
lembregtse
force-pushed
the
15.0-mig-queue_job_subscribe
branch
from
June 2, 2022 20:08
4ec6d5a to
24f6bd3
Compare
Contributor
Author
|
@luisg123v no, I somehow missed the feedback on the PR. @CasVissers-360ERP I just migrated the module and went through the steps, I did not modify that parameter. But I have removed it nevertheless. Thanks. |
lembregtse
force-pushed
the
15.0-mig-queue_job_subscribe
branch
3 times, most recently
from
June 2, 2022 20:26
74e3d46 to
e7b541f
Compare
lembregtse
force-pushed
the
15.0-mig-queue_job_subscribe
branch
from
June 2, 2022 20:29
e7b541f to
fc1d3fc
Compare
luisg123v
suggested changes
Jun 2, 2022
luisg123v
left a comment
luisg123v
left a comment
There was a problem hiding this comment.
- Missing OCA's standard README structure. You can check the template here and re-generate module's README running commands depicted here
- You seem to be adding an extra commit other than the migration one, there should be only one. If you consider changes there are actually required, maybe you should squash them
CC @moylop260
Contributor
|
Hello @lembregtse, I was planning to migrate this module on my own, but then I found this PR, so I'd like to avoid duplicates and help you if I can! |
Contributor
|
Hello @lembregtse, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.