Repository navigation
[IMP][16.0+] base_import_async: propagate context used during import #710
Description
Context
I was doing an asynchronous import on "account.asset" and realized that my assets were created but not visible.
After some investigation, I found that that it was caused by a field 'asset_type' that is set using the context key 'default_asset_type'
Proposition
I think that the context used during import should be propagate to the jobs created.
Or, at least, every key starting by 'default_...' .
It could be easily done by modifying the function on base_import.import:
def _job_prepare_context_before_enqueue_keys(self):Question
Since I know that it could generate a debate, I opened this issue before creating any PR.
Should we propagate the context? All of it? A sub part of it?
Activity
sbidoul commentedon Nov 20, 2024
This PR has some context: #432 (and links to much more context :)
AnizR commentedon Nov 20, 2024
Thanks! It gives more context but note that it refers to the "general" case and here, I would like to debate on the specific case of asynchronous import.
sbidoul commentedon Nov 20, 2024
At first sight, in the specific case of
base_import_asyncit makes sense to pass the same context that would be passed to a regular import.sbidoul commentedon Nov 20, 2024
There was #407, but this was apparently driven by the
languse case and was closed whenlangwent into the context ?amh-mw commentedon Nov 20, 2024
Also #613
github-actions commentedon May 25, 2025
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.