Encoding Object examples have invalid schema property

The keyword type should be $ref.

         addresses:
            # default Content-Type for arrays is based on the `inner` type (object shown, so `application/json` in this example)
            type: array
            items:
              type: '#/components/schemas/Address'

@handrews

I noticed 3.1.0 has a slightly different schema, albeit, valid. Lmk if you want that updated too.

          addresses:
            # default Content-Type for arrays is based on the _inner_ type (object shown, so `application/json` in this example)
            type: array
            items:
              type: object
              $ref: '#/components/schemas/Address'

cc @handrews let me know if this should be fixed too.

@jeremyfiel

@jeremyfiel I'm not sure what would need to be fixed in the 3.1 schema? I might be missing something.

the `type: object` is redundant with a `$ref` sibling

…

On Wed, Mar 1, 2023 at 2:16 PM Henry Andrews ***@***.***> wrote: @jeremyfiel <https://github.com/jeremyfiel> I'm not sure what would need to be fixed in the 3.1 schema? I might be missing something. — Reply to this email directly, view it on GitHub <#3170 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHU7MTNBUGCSSRETKM2U533WZ6OA3ANCNFSM6AAAAAAVHIZ7AU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

@jeremyfiel

@jeremyfiel I suspect I put it in there just to emphasize that you can put things next to $ref now :-) I don't much care one way or the other, but I think that's why it's like that.

i'm impartial.

Let's leave it as-is and just fix it for 3.0.4.

This has been fixed in 3.0.4 and we decided not to change it in 3.1.1.

Navigation Menu

Repository navigation

Encoding Object examples have invalid schema property #3170

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Encoding Object examples have invalid schema property #3170

Description

Activity

jeremyfiel commented on Feb 24, 2023

handrews commented on Mar 1, 2023

jeremyfiel commented on Mar 1, 2023

handrews commented on Mar 2, 2023

jeremyfiel commented on Mar 2, 2023

handrews commented on Mar 5, 2023

handrews commented on Apr 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions