[nmn]

Updating some of the dependencies. For now I have not updated by major version to avoid any breaking changes.

[jgclark]

Thanks, @nmn. I'm really not competent to review the changes; but as I type I see that the 22.x CI check has failed.

@dwertheimer I scanned down the list and "react-loader-spinner" caught my eye. I didn't remember seeing it, and so I checked, and sure enough I can't see in our codebase. Are you using it?

[nmn]

@jgclark No, I'm not using react-loader-spinner. We can remove the dep if no one is using it. Will do.

[dwertheimer]

@jgclark No, I'm not using react-loader-spinner. We can remove the dep if no one is using it. Will do.

@jgclark I think I was using it at one point on a project but I went another direction, so @nmn I'm good with you deleting it.

@nmn It's been several years, so I think we might need to bite the bullet and upgrade major versions also and figure out what we need to fix.

[dwertheimer]

@jgclark Also the tests that are failing are the ones we have fixed in the branch we've been working on. What would you think of doing a squash/merge into main of that branch so we can get the tests back to passing.

[nmn]

@dwertheimer which branch did you fix the tests in? I can just rebase this branch to merge into that one.

[dwertheimer]

@nmn The branch we have been working in is called "main-perspectives-merge-with-debug"

[nmn]

npm test now passes locally for me. All the tests that were failing are tests that should be disabled.

[nmn]

@dwertheimer PR merged into your branch. Make sure you pull these changes as you continue to work on your branch. Hopefully this gets you far along enough to fix your problem.

[dwertheimer]

@nmn @jgclark Should we get on a brief Zoom call today to discuss what we can do to test and help? There are some nuances that I want to make sure @nmn is aware of.

…

On Wed, Dec 4, 2024 at 11:28 PM Naman Goel ***@***.***> wrote: @dwertheimer <https://github.com/dwertheimer> PR merged into your branch. Make sure you pull these changes as you continue to work on your branch. Hopefully this gets you far along enough to fix your problem. — Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEI6VCM4YVBTKNVE2GH3DT2D76B3AVCNFSM6AAAAABTBETWGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJZGQ2TCMBVGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[aaronpoweruser]

@dwertheimer I have some time I'll join.

[dwertheimer]

Fantastic. Let’s see when @nmn wants to do it.

…

On Thu, Dec 5, 2024 at 8:03 AM Aaron ***@***.***> wrote: @dwertheimer <https://github.com/dwertheimer> I have some time I'll join. — Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEI6VCV5OC67X2DTIE6U532EB2M7AVCNFSM6AAAAABTBETWGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRQG43TAMBRGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nmn]

Sorry, I don't think I'll have time for a zoom this week. Carry on without me.

[dwertheimer]

@nmn No worries. We can wait until you have some time to discuss.

[nmn]

It might be weeks. I'll be traveling and just contributing when I have some time.