Skip to content

Pr/dwertheimer/18 - #19

Merged
jgclark merged 14 commits into
mainfrom
pr/dwertheimer/18
Jun 15, 2021
Merged

jgclark merged 14 commits into
mainfrom
pr/dwertheimer/18

Conversation

@jgclark

@jgclark jgclark commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

I navigated around more in Github and then found a page which seems to show all the commits I need. Rather than giving me the option to merge, though, it only lets me create yet another PR. So trying this ...

dwertheimer and others added 14 commits June 12, 2021 20:39
Working around a bug/feature where the appendParagraph was not showing up in the Editor. It's better this way anyway, because I can ask the user whether to open it or not. :)
No functional changes. Just making the Linter happier
If item is a todo or list, etc. then don't delete it after using it for the title
Stuck on how to open a file that's in a folder. Pushing code so Jonathan can see it with the console logs.
testing projectNoteByFilename
Still not working
Moved question in the middle as a work-around so it should work on / and folder use cases. @jgclark pls let me know if you find anything else
Now that /nns is working, broke it out of the monolithic NoteHelpers and moved it to Filer. Tested both.
@jgclark
jgclark merged commit a5ba1b8 into main Jun 15, 2021
@jgclark
jgclark deleted the pr/dwertheimer/18 branch August 29, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants