Repository navigation
Updates to Templates #11 - #14
Merged
Merged
Conversation
Collaborator
Author
|
@dwertheimer may want to pitch in with ideas too? |
nmn
requested changes
Jun 12, 2021
Collaborator
Author
|
Fixing multiple definition: going back to a single file 'interpolation.js' file, though I don't think the name is very clear. I was trying to make a smaller file where it was clearer that people should add new functions, but circular defintions stopped that. (PS I'm finding my way around the GitHub extensions in VSC quite confusing for PRs, so apologies if I goof in the process.) |
I had hoped to make two smaller files from interpolation.js to make it easier for other authors to know where to put functions that extend the Templates. But it wasn't working out as being simpler, so this is now mostly tweaks to names. PS I don't find 'interpolation.js' very clear, but I'm not going to try and complicate the PR further by renaming it myself. I would suggest 'processTemplate' though.
Collaborator
Author
|
Not having this resolved was causing me increasing pain as it was blocking getting other code released. So, as I've not had any comments in 5 days, I've gone ahead and made the commits. The main changes are:
|
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structure and readability changes only, I hope.