Skip to content

Correct missing single quote - #13

Merged
jgclark merged 1 commit into
NotePlan:mainfrom
dwertheimer:dailyJournal
Jun 12, 2021
Merged

jgclark merged 1 commit into
NotePlan:mainfrom
dwertheimer:dailyJournal

Conversation

@dwertheimer

Copy link
Copy Markdown
Collaborator

This missing quote in the default _configuration setup was keeping _configuration from loading by the plugin (throws an error)

This missing quote in the default _configuration setup was keeping _configuration from loading by the plugin (throws an error)
@dwertheimer

Copy link
Copy Markdown
Collaborator Author

@jgclark Fixing a bug in the default template creation which caused the config file to not load. May send you some other suggestions, but wanted to get this bug fixed right away.

@jgclark jgclark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving quickly, so we can make progress.

@jgclark
jgclark merged commit 433e805 into NotePlan:main Jun 12, 2021
@jgclark

jgclark commented Jun 12, 2021

Copy link
Copy Markdown
Collaborator

BTW, ... now I've looked more closely I see this is for the auto-generated script. This will get overwritten next time someone use the build system.
I will as well fix this in the underlying script from @nmn (configuration.js), and I'm in the process of raising a wider PR that will include this. Please do get involved in that discussion ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants