Skip to content

Nodeclipse issue #189 - workaround for node issue 25266 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvi merged 1 commit into from
Jul 13, 2015
Merged

Nodeclipse issue #189 - workaround for node issue 25266 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ools/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebuggerCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public enum DebuggerCommand {
BREAK("break"),
EXCEPTION("exception"),
AFTER_COMPILE("afterCompile"),
COMPILE_ERROR("compileError"),
SCRIPT_COLLECTED("scriptCollected"),
;

Expand Down
21 changes: 21 additions & 0 deletions ...ugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DefaultResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,27 @@ BreakpointProcessor get(DefaultResponseHandler instance) {
command2EventProcessorGetter.put(DebuggerCommand.BREAK /* event */, bppGetter);
command2EventProcessorGetter.put(DebuggerCommand.EXCEPTION /* event */, bppGetter);

// Nodeclipse Issue 189 / node issue 25266
// Treat the "compileError" event as if it were
// the "afterCompile" event...
// This is a workaround for an apparent problem in node
// that was introduced in v0.11.14. The reported problem
// is that when a new script is required and compiled,
// the compileError event is generated instead of the
// afterCompile event.
// If this does in fact turn out to be a node issue,
// then presumably this workaround would be version-specific,
// and would only need to be activated for certain versions
// of node.
command2EventProcessorGetter.put(DebuggerCommand.COMPILE_ERROR /* event */,
new ProcessorGetter() {
@Override
AfterCompileProcessor get(DefaultResponseHandler instance) {
return instance.afterCompileProcessor;
}
});
// <end> Nodeclipse Issue 189 / node issue 25266

command2EventProcessorGetter.put(DebuggerCommand.AFTER_COMPILE /* event */,
new ProcessorGetter() {
@Override
Expand Down