Skip to content

Add maven / tycho support (n-1) #40

Closed
Closed
Add maven / tycho support (n-1)#40
Assignees
paulvi
Labels
enhancement
Milestone
0.5 coffee

Description

@paulvi
paulvi
opened on May 17, 2013

After or before analogical task for coffeescript-eclipse Nodeclipse/coffeescript-eclipse#3
(but exactly in the same maner)

add maven / tycho support

Activity

  1. ghost assigned
    pushkar-g
    on May 17, 2013
  2. paulvi
    added a commit that references this issue on Aug 19, 2013

    #40 Maven build example (Node.js bundles & Chromdevtools are not

    9ea7380
  3. ghost assigned
    paulvi
    on Aug 19, 2013

  4. paulvi commented on Aug 19, 2013

    @paulvi
    paulvi
    on Aug 19, 2013
    MemberAuthor

    @tomotaro1065 I started adding option to build as Maven/tycho (see commit above: just pom.xml files)

    Can you tell what plugins and features are required from chromedevtools? Let's included in Maven build only those required.

  5. tomotaro1065 commented on Aug 19, 2013

    @tomotaro1065
    tomotaro1065
    on Aug 19, 2013
    Member

    We need following plugins and features.

    plugins/org.chromium.debug.corehttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    plugins/https://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    org.chromium.debug.uihttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.ui
    plugins/https://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    org.chromium.debughttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug
    plugins/https://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    org.chromium.sdk.wip.eclipsehttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.sdk.wip.eclipse
    plugins/https://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    org.chromium.sdkhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.sdk

    features/org.chromium.debughttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.debug
    features/org.chromium.sdkhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.sdk

    2013/8/19 Paul Verest notifications@github.com

    @tomotaro1065 https://github.com/tomotaro1065 I started adding option
    to build as Maven/tycho (see commit above: just pom.xml files)

    Can you tell what plugins and features are required from chromedevtools?
    Let's included in Maven build only those required.

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-22868334
    .

    http://www.nodeclipse.org/

    blog: http://d.hatena.ne.jp/tomotaro1065/
    twitter: @tomotaro1065

  6. paulvi commented on Aug 19, 2013

    @paulvi
    paulvi
    on Aug 19, 2013
    MemberAuthor

    I will add pom.xml for mentioned projects.

    What about Node.js bundles? For 0.5 release will you keep them inside or extract outside?

  7. paulvi commented on Aug 19, 2013

    @paulvi
    paulvi
    on Aug 19, 2013
    MemberAuthor

    Already answered in #17

  8. paulvi
    added a commit that references this issue on Aug 22, 2013

    #40 add pom.xml to all used projects

    87b5900

  9. paulvi commented on Aug 22, 2013

    @paulvi
    paulvi
    on Aug 22, 2013
    MemberAuthor

    @tomotaro1065

    We need following plugins and features.

    Please check if the list is correct. Your list was hard to read. (Check this post for better Markdown usage)

    I have added all needed pom's for projects mentioned here (see commit above)

    However current build mvn package gives error

    [ERROR] Internal error: java.lang.RuntimeException: org.osgi.framework.BundleException: Bundle org.chromium.sdk.wip.eclipse cannot be resolved
[ERROR] Resolution errors:
[ERROR] Bundle org.chromium.sdk.wip.eclipse - Missing Constraint: Import-Package: org.eclipse.core.runtime; version="0.0.0"
[ERROR] -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: org.osgi.framework.BundleException: Bundle org.chromium.sdk.wip.eclipse cannot be resolved

    Do you have an idea?

  10. tomotaro1065 commented on Aug 22, 2013

    @tomotaro1065
    tomotaro1065
    on Aug 22, 2013
    Member
    • features/org.chromium.sdhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.sdk

    is

    • features/org.chromium.sdkhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.sdk

    I don't have any idea about the error.
    What happens if you reject
    plugins/org.chromium.sdk.wip.eclipsehttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.sdk.wip.eclipse
    from
    the build list?

    2013/8/22 Paul Verest notifications@github.com

    @tomotaro1065 https://github.com/tomotaro1065

    We need following plugins and features.

    Please check if the list is correct. Your list was hard to read. (Check
    this post for better Markdown usage)

    • plugins/org.chromium.debug.corehttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.core
    • plugins/org.chromium.debug.uihttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug.ui
    • plugins/org.chromium.debughttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.debug
    • plugins/org.chromium.sdk.wip.eclipsehttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.sdk.wip.eclipse
    • plugins/org.chromium.sdkhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/plugins/org.chromium.sdk
    • features/org.chromium.debughttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.debug
    • features/org.chromium.sdhttps://github.com/Nodeclipse/nodeclipse-1/tree/master/chromedevtools/features/org.chromium.sdk

    I have added all needed pom's for projects mentioned here (see commit
    above)87b5900

    However current build mvn package gives error

    [ERROR] Internal error: java.lang.RuntimeException: org.osgi.framework.BundleException: Bundle org.chromium.sdk.wip.eclipse cannot be resolved
    [ERROR] Resolution errors:
    [ERROR] Bundle org.chromium.sdk.wip.eclipse - Missing Constraint: Import-Package: org.eclipse.core.runtime; version="0.0.0"
    [ERROR] -> [Help 1]
    org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: org.osgi.framework.BundleException: Bundle org.chromium.sdk.wip.eclipse cannot be resolved

    Do you have an idea?

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-23085613
    .

    http://www.nodeclipse.org/

    blog: http://d.hatena.ne.jp/tomotaro1065/
    twitter: @tomotaro1065

  11. paulvi commented on Aug 22, 2013

    @paulvi
    paulvi
    on Aug 22, 2013
    MemberAuthor

    I got some ideas from http://www.eclipse.org/community/eclipse_newsletter/2013/august/article3.php

    I need to add something like this:

      <build>
    <plugins>
      <plugin>
        <groupId>org.eclipse.tycho</groupId>
        <artifactId>target-platform-configuration</artifactId>
        <configuration>
          <dependency-resolution>
            <extraRequirements>
              <requirement>
                <type>eclipse-plugin</type>
                <id>org.eclipse.jface.text</id>
                <versionRange>0.0.0</versionRange>
              </requirement>
            </extraRequirements>
          </dependency-resolution>
        </configuration>
      </plugin>
    </plugins>
  </build>

  12. paulvi commented on Aug 23, 2013

    @paulvi
    paulvi
    on Aug 23, 2013
    MemberAuthor

    Build succeeded

  13. paulvi commented on Aug 23, 2013

    @paulvi
    paulvi
    on Aug 23, 2013
    MemberAuthor
    [INFO] parent ............................................ SUCCESS [0.000s]
[INFO] org.chromium.parent ............................... SUCCESS [0.016s]
[INFO] org.chromium.sdk .................................. SUCCESS [7.207s]
[INFO] org.chromium.debug.core ........................... SUCCESS [1.576s]
[INFO] org.chromium.sdk.wip.eclipse ...................... SUCCESS [0.218s]
[INFO] org.chromium.debug.ui ............................. SUCCESS [1.997s]
[INFO] org.nodeclipse.bundle.coffee-script ............... SUCCESS [0.405s]
[INFO] org.nodeclipse.bundle.express ..................... SUCCESS [1.482s]
[INFO] org.nodeclipse.ui ................................. SUCCESS [1.077s]
[INFO] org.chromium.sdk.feature .......................... SUCCESS [0.483s]
[INFO] org.chromium.debug ................................ SUCCESS [0.266s]
[INFO] org.chromium.debug.feature ........................ SUCCESS [0.421s]
[INFO] org.nodeclipse.debug .............................. SUCCESS [0.608s]
[INFO] org.nodeclipse .................................... SUCCESS [0.359s]
[INFO] org.nodeclipse.bundle.coffee_script.feature ....... SUCCESS [0.187s]
[INFO] org.nodeclipse.bundle.express.feature ............. SUCCESS [0.234s]
[INFO] org.nodeclipse.site ............................... SUCCESS [4.961s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

    I had to rename feature's name in chromium to add ".feature" as they have the same ID as plugins.

    Let's make all feature to have ".feature" suffix.

    I have not committed yet. Too late.

  14. paulvi
    added a commit that references this issue on Aug 23, 2013

    Nodeclipse#40 Maven/tycho build passes (rename 2 chromium features: a…

    fe5eb85
  15. paulvi
    closed this as completedin 9ce3e9con Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions