Skip to content

retrieve timestamps in bufferfunction #27

Open

Description

@samuelgarcia

Is there a simple way to get timestamp info in the callback "bufferfunction" ?

Activity

  1. Claybarn commented on May 20, 2020

    @Claybarn
    Collaborator

    No, but that is functionality that should exist. Could help you with that, but just to be sure:

    1. You want timestamps for the buffer and not other events?

    2. You can't use spike events for your application? They are created whenever OE detects a spike (as long as spike detector/viewer are in the signal chain) with a fixed buffer size of 18 centered around the spike?

    Let me know.

  2. samuelgarcia commented on May 20, 2020

    @samuelgarcia
    Author

    I would like to have :

            def bufferfunction(self, n_arr, timestamp):
                    """Access to voltage data buffer. Returns events""" 
                    events = []
                    return events
    

    instead of

            def bufferfunction(self, n_arr):
                    """Access to voltage data buffer. Returns events""" 
                    events = []
                    return events
    

    I think it is quite easy todo but it will break existing pluing.

  3. samuelgarcia commented on May 20, 2020

    @samuelgarcia
    Author

    I need to timestmap spike from a given buffer to align then with other events.

    My goal is to implement a new spike detector with my tridesclous realtime engine.

  4. samuelgarcia commented on May 20, 2020

    @samuelgarcia
    Author

    parralel question : do you plan to merge cmake_buuild into master ?
    I could make some proposal so.

  5. Claybarn commented on May 20, 2020

    @Claybarn
    Collaborator

    It might not work with your setup, but I would at least think about using spike events as it would be the easiest to do at this point. The spike detector in OE doesn't sort the spikes, it just detects if one occurs or not and passes it to the other processors with the voltage trace of the spike and the timestamp.

  6. Claybarn commented on May 20, 2020

    @Claybarn
    Collaborator

    As for merging the cmake build branch, I would rather start with the open-ephys-plugins one and get it up to speed as they have the more dedicated resources to maintain it. Although their version didn't work for me on Mac.

  7. samuelgarcia commented on May 20, 2020

    @samuelgarcia
    Author

    The open-ephys-plugin:

    • diverge from this one
    • they don't have issue or PR.
    • C++ compiles but python code do not.
    • should rebase on your master

    I think the offcial one should be here.

    I am planing to ask to openephys team to add another spike stream type with (timestamp, label).
    This would be lighter and would allow to make spike sorting in real time.

    If you prefer not to merge cmake_build (last commit 16 Nov 2019) into your master (last commit 11 june 2019) where do you advice me to make a PR ? Directly into cmake_build ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions