You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
please always run pkglint -Wall and review and fix possible warnings: in that case GITHUB_PROJECT should be sorted... but... actually... GITHUB_PROJECT can be completely omitted because it is derived from PKGBASE that should be already tintin (so, please remove completely GITHUB_PROJECT not needed redefinition)
Instead of hardcoding GITHUB_RELEASE with the version number please change it to GITHUB_RELEASE= ${PKGVERSION_NOREV}. In this way when updating just the version number in DISTNAME needs to be bumped.
HAS_CONFIGURE is not needed because there is already GNU_CONFIGURE
Activity
iamleot commentedon Aug 19, 2022
@kflu Hello!
Possible minor suggestions:
pkglint -Walland review and fix possible warnings: in that caseGITHUB_PROJECTshould be sorted... but... actually...GITHUB_PROJECTcan be completely omitted because it is derived fromPKGBASEthat should be alreadytintin(so, please remove completelyGITHUB_PROJECTnot needed redefinition)GITHUB_RELEASEwith the version number please change it toGITHUB_RELEASE= ${PKGVERSION_NOREV}. In this way when updating just the version number inDISTNAMEneeds to be bumped.HAS_CONFIGUREis not needed because there is alreadyGNU_CONFIGUREThank you!
kflu commentedon Aug 19, 2022
OK just fixed all the problems as suggested. Please see pkgsrc-wip f4ee8f05ca07be36d7ad34ccc733f5366dd423fd
felinks: catch up with upstream repo rename. Update to 0.15.1
devel/git-cliff: update to 0.9.2
graphics/oculante: update to 0.6.38
graphics/oculante: update to 0.6.38
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
devel/hs-pretty-simple: Update to 4.1.2.0
234 remaining items
stgit: update to 2.4.7.
devel/hexpatch: update to 1.9.0
(parallel/R-promises) Updated 1.2.0.1 to 1.3.2
(www/R-webshot) Updated 0.5.2 to 0.5.5
graphics/wallust: update to 3.2.0
kyua: update to 0.14.1.
shells/yash: update to 2.59
libsidplayfp: update to 2.16.0.
devel/ruby-io-console: update to 0.8.2
py-nh3: update to 0.3.3.
filesystems/fuse-bindfs: update to 1.18.4
net/ttl: update to 0.21.0
www/ruby-cgi: update to 0.5.2
Update to 0.41
R-webfakes: update to 1.5.0.