Skip to content

Add opt-in iPad menu edge swipe - #100

Merged
SandiyosDev merged 2 commits into
NearFrame:mainfrom
alantangok:alan/feature/ipad-menu-edge-swipe
Oct 17, 2026
Merged

SandiyosDev merged 2 commits into
NearFrame:mainfrom
alantangok:alan/feature/ipad-menu-edge-swipe

Conversation

@alantangok

@alantangok alantangok commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add an opt-in Menu Edge Swipe preference: Off (default), Left Edge, or Right Edge. No edge recognizer is registered when Off.

  • Preserve existing stored Left/Right values (0/1); append Off as 2.

  • Open the session menu once when the selected direct-touch edge gesture begins, and refresh host data through the existing getHostUserData() method.

  • Remove the explicit delaysTouchesBegan = true setting.

  • Keep MenuSwipeEdge with the shared settings enums in ParsecSDKBridge.swift.

  • Known limitation from device testing: the edge menu works in full screen, but did not activate with right-side Slide Over or when OpenParsec was windowed.

Verification

  • 19 scoped checks passed: defaults/UI wiring, enum placement, stored values, and the actual extracted recognizer registration/handler code executed with test doubles. The previous revision failed the relevant opt-in/delay/reuse checks.
  • Unsigned Release iOS device build succeeded; git diff --check passed.
  • GitHub Actions archive and IPA packaging passed for head 7117aed: https://github.com/hugeBlack/OpenParsec/actions/runs/38923341136.
  • CI checked out merge 9e37c2164d47a60b01b60f1979492a6ad2e4fb91 (main b49c720 + this PR); artifact SHA256 was verified before preparing the signed device build.
  • The feature diff contains only five app source files. No project-file, scripts, checkpoint or agent artifacts are included.

Device validation and known limitation

Manual results reported on 2026-10-16 for signed OpenParsec 1.4.0 build 225 on an iPad Air (5th generation), iPadOS 26.6 (23G71):

Tested configuration Observed edge-menu result
OpenParsec full screen Works
Slide Over enabled, with its window on the right Does not activate
OpenParsec in windowed mode Does not activate

The observed limitation on this device is full-screen use only. Slide Over and windowed-mode compatibility have not passed. These are manual observations of the tested configurations; edge-by-edge coverage and drag timing were not separately reported. The underlying cause has not been instrumented.

The prior Wi-Fi XCTest attempts timed out waiting for WebDriverAgent readiness; the results above come from the user's subsequent manual test, not automation. Each preference change should be tested after reconnecting, because the recognizer is configured when its controller is created.

Addresses #100 (comment). Split from #93.

@SandiyosDev

Copy link
Copy Markdown
Collaborator

I can take this as an opt-in. default it to off, drop delaysTouchesBegan since it holds every touch that starts at that edge and that's where touchpad drags start, call getHostUserData instead of copying its body, and put the enum with the other settings enums in the bridge

did you test the right edge with Slide Over? iPadOS owns that edge

@alantangok alantangok changed the title Add configurable iPad menu edge swipe Add opt-in iPad menu edge swipe Oct 16, 2026
@alantangok

Copy link
Copy Markdown
Contributor Author

Thanks for the clear review. The four code requests are addressed in 7117aed:

  • Off is now the default and registers no edge recognizer. Left/Right remain explicit options, with their existing stored values preserved.
  • Removed the explicit touch-begin delay.
  • The menu callback calls the existing getHostUserData().
  • Moved MenuSwipeEdge to ParsecSDKBridge.swift alongside the other settings enums.

Verification: 19 scoped settings/gesture checks passed (including extracted source with test doubles), the unsigned Release device build passed, and CI archive/IPA packaging passed.

To answer the Slide Over question directly: the right-edge/system-gesture interaction is not yet physically verified. The iPad Air (5th generation, iPadOS 26.6) Wi-Fi XCTest attempt repeatedly timed out waiting for WebDriverAgent readiness. A signed build 225 and manual Off/Left/Right/Slide Over checks are being supplied for device testing; I will report that result separately rather than claim it has passed.

@alantangok

Copy link
Copy Markdown
Contributor Author

Follow-up physical device results for signed OpenParsec 1.4.0 build 225, tested manually on the iPad Air (5th generation), iPadOS 26.6 (23G71):

  • The edge menu works when OpenParsec is full screen.
  • It does not activate with Slide Over enabled and the Slide Over window on the right.
  • It also does not activate when OpenParsec itself is in windowed mode.

So the current observed limitation is full-screen use only on this device. This confirms that the Slide Over/windowed cases cannot be reported as working. Edge-by-edge coverage and ordinary drag timing were not separately reported, and the cause has not been instrumented.

I have updated the PR description with these results and kept the application code unchanged. The remaining review question is whether to document/accept this scope or address these modes in a follow-up; no compatibility fix for those modes is claimed.

@SandiyosDev
SandiyosDev merged commit e4ba9e2 into NearFrame:main Oct 17, 2026
3 checks passed
@SandiyosDev

Copy link
Copy Markdown
Collaborator

full screen only is fine since its off by default, so merged
my 2.0 plans has a left edge swipe that brings the menu back when the overlay is hidden, Ill build that on top of yours

@alantangok

Copy link
Copy Markdown
Contributor Author

thanks for merging and sharing the 2.0 plans, @SandiyosDev!

SandiyosDev added a commit to SandiyosDev/reOpenParsec that referenced this pull request Oct 17, 2026
SandiyosDev added a commit to SandiyosDev/reOpenParsec that referenced this pull request Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants