Repository navigation
Add opt-in iPad menu edge swipe - #100
Conversation
|
I can take this as an opt-in. default it to off, drop delaysTouchesBegan since it holds every touch that starts at that edge and that's where touchpad drags start, call getHostUserData instead of copying its body, and put the enum with the other settings enums in the bridge did you test the right edge with Slide Over? iPadOS owns that edge |
|
Thanks for the clear review. The four code requests are addressed in
Verification: 19 scoped settings/gesture checks passed (including extracted source with test doubles), the unsigned Release device build passed, and CI archive/IPA packaging passed. To answer the Slide Over question directly: the right-edge/system-gesture interaction is not yet physically verified. The iPad Air (5th generation, iPadOS 26.6) Wi-Fi XCTest attempt repeatedly timed out waiting for WebDriverAgent readiness. A signed build 225 and manual Off/Left/Right/Slide Over checks are being supplied for device testing; I will report that result separately rather than claim it has passed. |
|
Follow-up physical device results for signed OpenParsec 1.4.0 build 225, tested manually on the iPad Air (5th generation), iPadOS 26.6 (23G71):
So the current observed limitation is full-screen use only on this device. This confirms that the Slide Over/windowed cases cannot be reported as working. Edge-by-edge coverage and ordinary drag timing were not separately reported, and the cause has not been instrumented. I have updated the PR description with these results and kept the application code unchanged. The remaining review question is whether to document/accept this scope or address these modes in a follow-up; no compatibility fix for those modes is claimed. |
|
full screen only is fine since its off by default, so merged |
|
thanks for merging and sharing the 2.0 plans, @SandiyosDev! |
Summary
Add an opt-in Menu Edge Swipe preference: Off (default), Left Edge, or Right Edge. No edge recognizer is registered when Off.
Preserve existing stored Left/Right values (
0/1); append Off as2.Open the session menu once when the selected direct-touch edge gesture begins, and refresh host data through the existing
getHostUserData()method.Remove the explicit
delaysTouchesBegan = truesetting.Keep
MenuSwipeEdgewith the shared settings enums inParsecSDKBridge.swift.Known limitation from device testing: the edge menu works in full screen, but did not activate with right-side Slide Over or when OpenParsec was windowed.
Verification
git diff --checkpassed.7117aed: https://github.com/hugeBlack/OpenParsec/actions/runs/38923341136.9e37c2164d47a60b01b60f1979492a6ad2e4fb91(mainb49c720+ this PR); artifact SHA256 was verified before preparing the signed device build.Device validation and known limitation
Manual results reported on 2026-10-16 for signed OpenParsec 1.4.0 build 225 on an iPad Air (5th generation), iPadOS 26.6 (23G71):
The observed limitation on this device is full-screen use only. Slide Over and windowed-mode compatibility have not passed. These are manual observations of the tested configurations; edge-by-edge coverage and drag timing were not separately reported. The underlying cause has not been instrumented.
The prior Wi-Fi XCTest attempts timed out waiting for WebDriverAgent readiness; the results above come from the user's subsequent manual test, not automation. Each preference change should be tested after reconnecting, because the recognizer is configured when its controller is created.
Addresses #100 (comment). Split from #93.