Skip to content

[no-ci] CI: fix Node probe summary bold formatting and run probe daily #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juenglin merged 1 commit into from
Oct 28, 2026
Merged

[no-ci] CI: fix Node probe summary bold formatting and run probe daily #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/runner-trust-probe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ name: "CI: Runner trust probe"

on:
schedule:
# Weekly on Mondays at 06:23 UTC
- cron: "23 6 * * 1"
# Daily at 06:00 PST (14:00 UTC)

@coderabbitai coderabbitai Bot Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

suggestion: Use a timezone-neutral schedule comment. 0 14 * * * runs at 14:00 UTC. It is 06:00 PST only during standard time. During daylight saving time, it is 07:00 PDT. Change the comment to Daily at 14:00 UTC.

- cron: "0 14 * * *"
workflow_dispatch:
inputs:
label-filter:
Expand Down
6 changes: 3 additions & 3 deletions ci/tools/runner_trust_probe_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ module.exports = async function runNodeTrustProbe({

const tlsResult = await probeEndpoint();
const rows = [
['Node version', versionOk ? '**PASS**' : '**FAIL**', `\`${version}\` (require Node 24 \`>= v24.22.1\`; \`execPath=${execPath}\`)`],
['Node env overrides', '**INFO**', `\`NODE_OPTIONS=${nodeOptions}\`, \`NODE_EXTRA_CA_CERTS=${extraCa}\`, \`NODE_USE_SYSTEM_CA=${useSystemCa}\``],
['Node rejects test endpoint', `**${tlsResult.status}**`, tlsResult.detail],
['Node version', versionOk ? '<strong>PASS</strong>' : '<strong>FAIL</strong>', `\`${version}\` (require Node 24 \`>= v24.22.1\`; \`execPath=${execPath}\`)`],
['Node env overrides', '<strong>INFO</strong>', `\`NODE_OPTIONS=${nodeOptions}\`, \`NODE_EXTRA_CA_CERTS=${extraCa}\`, \`NODE_USE_SYSTEM_CA=${useSystemCa}\``],
['Node rejects test endpoint', `<strong>${tlsResult.status}</strong>`, tlsResult.detail],
];

await core.summary
Expand Down
Loading