Repository navigation
feat(cuda.core): share VirtualMemoryResource buffers with fabric handles #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andy-Jost
wants to merge
12
commits into
NVIDIA:main
Choose a base branch
from
Andy-Jost:ajost/vmm-fabric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+903
−113
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f128963
refactor(cuda.core): rename VirtualMemoryIPCBufferDescriptor to Virtu…
Andy-Jost e30f0bf
feat(cuda.core): share VirtualMemoryResource buffers with fabric handles
Andy-Jost d6846d9
fix(cuda.core): harden the fabric transport after review and GPU runs
Andy-Jost 04f6145
fix(cuda.core): drop an unreachable return in the VMM allocation-erro…
Andy-Jost bd69003
Merge remote-tracking branch 'origin/main' into ajost/vmm-fabric
Andy-Jost 34e5f37
test(cuda.core): let the fabric probe skip only on a refused allocation
Andy-Jost 7dc241c
Merge remote-tracking branch 'origin/main' into ajost/vmm-fabric
Andy-Jost 45ed268
Merge origin/main (the squashed #3229 rename) into ajost/vmm-fabric
Andy-Jost 196eeaa
test(cuda.core): skip fabric tests only on cuda.core's allocation note
Andy-Jost 4b9fc22
Merge remote-tracking branch 'origin/main' into ajost/vmm-fabric
Andy-Jost 57e8573
docs(cuda.core): say why the fabric attribute can be true where alloc…
Andy-Jost 26698eb
Merge remote-tracking branch 'origin/main' into ajost/vmm-fabric
Andy-Jost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The untested thing raises an eyebrow from me. Ideally we have some way of testing the hot paths.
One maybe overkill idea is to simulate the fabric environment by building our own driver library that lies about the situation. Some back and forth with an agent can quickly produce something vibecoded here that works, see the gist below as an example
fabric_sim.md
Something like this is fairly heavy but the three options seem to all be heavy:
FWIW, the above gets me from 18 skips down to 1 on a regular machine.