Repository navigation
Fix coredump tests on free-threaded builds - #3226
Merged
Merged
Conversation
github-actions
Bot
added
the
cuda.bindings
jpascucci-nv
approved these changes
Oct 26, 2026
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Mark coredump tests thread-unsafe cuda_bindings_13/tests/test_cuda.py |
The coredump attribute round-trip test, bool-storage test, and generation-flags test are marked thread_unsafe. Their test logic is unchanged. |
Possibly related issues
- [BUG]: Free-threaded CI: coredump bool regression test races on application-wide settings #3225 — The issue describes a parallel-test race involving the bool-storage test and proposes the marker added here.
Possibly related PRs
- NVIDIA/cuda-python#3095 — That PR introduced the coredump tests changed here.
- NVIDIA/cuda-python#3176 — That PR introduced parallel test execution and use of
thread_unsafemarkers.
Suggested labels: cuda.bindings, test
Suggested reviewers: rwgk
Priority:
Change: Bug fix · Severity of issue fixed: Medium
Merge Risk: 
5f93b
-
The coredump tests are marked to avoid concurrent execution, with no identified issue blocking merge after normal checks.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Contributor
|
Closed
1 task done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coredump APIs are not threadsafe, since they have global state. Therefore the /occasionally/ fail on in CI on free-threaded Python builds where we run tests in parallel. This just marks these tests as thread-unsafe so pytest will do the right thing.