[no-ci] Update CONTRIBUTING.md to include instructions about coderabbit by jpascucci-nv · Pull Request #3189 · NVIDIA/cuda-python

jpascucci-nv · 2026-10-22T17:54:27Z

[no-ci]

Description

closes #2137

Added the text from CCCL's coderabbit.rst to our CONTRIBUTING.md, per #2137 's rollout step 4.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

closes NVIDIA#2137 Added the text from CCCL's coderabbit.rst to our CONTRIBUTING.md

coderabbitai · 2026-10-22T17:58:14Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: 2fd84a6

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: NVIDIA/cuda-python
Branch: main
File: .coderabbit.yaml
Commit: c968fcc
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 8f0d32e4-e967-45c4-a1b8-2ef8a054ce9a

Commits

Reviewing files that changed from the base of the PR and between f72a09e and 2fd84a6.

Files selected for processing: 2

.github/CODERABBIT.md
CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

Documentation
- Expanded the contribution guide with CodeRabbit review guidance, including how to request a review or full review and use commands for help, configuration, summaries, pausing, resuming, and disabling automatic reviews.
- Added guidance on how CodeRabbit configuration is selected for same-repository and fork pull requests, inspecting or exporting settings, repository settings, and path-specific instructions.
- Clarified that review comments are advisory and provided guidance for keeping configuration focused on high-impact issues while avoiding noisy comments.

The pull request adds CodeRabbit review guidance to CONTRIBUTING.md and adds .github/CODERABBIT.md with repository configuration and review guidance.

Changes: CodeRabbit contribution guidance

Layer / File(s)	Summary
Document CodeRabbit review workflow `CONTRIBUTING.md`, `.github/CODERABBIT.md`	The contribution guide links to CodeRabbit guidance and describes review commands and maintainer evaluation of feedback. The repository guide describes configuration behavior, commands, and review guidance.

Assessment against linked issues

Objective	Addressed	Explanation
Enable automatic reviews with the requested `.coderabbit.yaml` configuration [`#2137`]	❌	The change does not add `.coderabbit.yaml` or enable automatic reviews.
Document the maintainer review workflow, including manual review, pause/resume, opt-out, and resolved configuration [`#2137`]	✅

Priority: Low

Change: Other

Merge Risk: Minimal · up to 2fd84

The documentation-only change has no established merge-blocking risk.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Source mode: Auto
Repository: NVIDIA/cuda-python
Branch: main
File: .coderabbit.yaml
Commit: c968fcc
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 2f8e1792-5106-4064-8309-4bd84a3d3c53

📥 Commits

Reviewing files that changed from the base of the PR and between c968fcc and 2691bfa.

📒 Files selected for processing: 1

CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

github-actions · 2026-10-22T18:14:01Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

rwgk

Me:

I wonder, is CONTRIBUTING.md the best home for the added information?

It seems more like information for maintainers, not contributors?

codex GPT-6.1-Sol ultra:

I found one documentation issue:

[P2] Qualify which branch supplies configuration. Lines 250–251 say the PR branch’s configuration is used. CodeRabbit’s command reference says fork PRs use the target branch’s configuration. Mention that exception so contributors don’t expect configuration changes in a fork to affect their review.

On placement, I agree with you. Configuration, noise policy, and maintainer review responsibilities fit better in maintainer documentation. Issue #2137 explicitly requests that, and the source material lives under CCCL’s docs/maintainers/.

I’d move the detailed section into .github/CODERABBIT.md, following the existing maintainer runbook precedent. Keep a short note in CONTRIBUTING.md explaining that CodeRabbit feedback is advisory, with a link to the operational guidance.

No other issues found. Documentation-only review; no files changed or tests run.

rwgk · 2026-10-22T19:07:16Z

I added [no-ci] to the PR title, since this PR only touches only .md files.

jpascucci-nv · 2026-10-22T19:11:09Z

@rwgk That's where Rob told me to put it. I'll update the doc for the P2 issue, though.

rwgk · 2026-10-22T19:20:35Z

@rwgk That's where Rob told me to put it. I'll update the doc for the P2 issue, though.

I believe it'll be quite distracting for contributors. @rparolin WDYT about following the .github/RELEASE-core.md precedent?

jpascucci-nv · 2026-10-22T19:26:08Z

@rwgk That's where Rob told me to put it. I'll update the doc for the P2 issue, though.

I believe it'll be quite distracting for contributors. @rparolin WDYT about following the .github/RELEASE-core.md precedent?

The section that says "Pull Request Reviews" and "Review Guidance" is actually for contributors to know how they can control coderabbit. It's really only the Configuration section that makes sense to be moved, maybe.

jpascucci-nv · 2026-10-26T16:13:28Z

@rwgk Updated as we discussed in the meeting.

coderabbitai

Actionable comments posted: 1

Review info

Run configuration

Source mode: Auto
Repository: NVIDIA/cuda-python
Branch: main
File: .coderabbit.yaml
Commit: c968fcc
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 0ea55117-4f95-46e4-a625-4489443d98f9

Commits

Reviewing files that changed from the base of the PR and between 8ee9fce and d84fbd7.

Files selected for processing: 2

.github/CODERABBIT.md
CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

rwgk

Thanks @jpascucci-nv, this looks great, I only have two small suggested changes for details.

Removed preview folders for the following PRs: - PR #2925 - PR #3133 - PR #3189 - PR #3208

Update CONTRIBUTING.md to include instructions about coderabbit

2691bfa

closes NVIDIA#2137 Added the text from CCCL's coderabbit.rst to our CONTRIBUTING.md

jpascucci-nv added this to the cuda.bindings 13.5.0 & 12.9.10 milestone Oct 22, 2026

jpascucci-nv requested review from rparolin and rwgk October 22, 2026 17:54

jpascucci-nv self-assigned this Oct 22, 2026

jpascucci-nv added documentation Improvements or additions to documentation bug Something isn't working P1 Medium priority - Should do and removed bug Something isn't working labels Oct 22, 2026

coderabbitai Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread CONTRIBUTING.md Outdated

jpascucci-nv added the cuda.core Everything related to the cuda.core module label Oct 22, 2026

rwgk reviewed Oct 22, 2026

View reviewed changes

rwgk changed the title ~~Update CONTRIBUTING.md to include instructions about coderabbit~~ [no-ci] Update CONTRIBUTING.md to include instructions about coderabbit Oct 22, 2026

Correct information about forks.

8ee9fce

jpascucci-nv added the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Oct 26, 2026

Update contributing and move configuring section to its own file

d84fbd7

github-actions Bot added the CI/CD CI/CD infrastructure label Oct 26, 2026

coderabbitai Bot reviewed Oct 26, 2026

View reviewed changes

Comment thread .github/CODERABBIT.md Outdated

Coderabbit suggestions

f72a09e

rwgk approved these changes Oct 26, 2026

View reviewed changes

Comment thread CONTRIBUTING.md Outdated

Comment thread .github/CODERABBIT.md Outdated

APply ralf's suggestions

2fd84a6

jpascucci-nv merged commit fd5f89d into NVIDIA:main Oct 26, 2026
27 checks passed

leofang mentioned this pull request Oct 27, 2026

gh-pages deploy failing: artifact crossed Pages publish cap on Oct 26 #3231

Open

github-actions Bot pushed a commit that referenced this pull request Oct 27, 2026

Clean up PR preview folders for 4 closed/merged PRs

3a547db

Removed preview folders for the following PRs: - PR #2925 - PR #3133 - PR #3189 - PR #3208

Conversation

jpascucci-nv commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Summary by CodeRabbit

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

rwgk commented Oct 22, 2026

Uh oh!

jpascucci-nv commented Oct 22, 2026

Uh oh!

rwgk commented Oct 22, 2026

Uh oh!

jpascucci-nv commented Oct 22, 2026

Uh oh!

jpascucci-nv commented Oct 26, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpascucci-nv commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

github-actions Bot commented Oct 22, 2026 •

edited

Loading