Skip to content

pathfinder: support cuDSS 1.0 library names - #3188

Merged
jpascucci-nv merged 2 commits into
NVIDIA:mainfrom
jpascucci-nv:issue3180
Oct 22, 2026
Merged

jpascucci-nv merged 2 commits into
NVIDIA:mainfrom
jpascucci-nv:issue3180

Conversation

@jpascucci-nv

Copy link
Copy Markdown
Contributor

Description

closes #3180

cuDSS 1.0 changed the Linux SONAME from libcudss.so.0 to libcudss.so.1 and the Windows DLL name from cudss64_0.dll to cudss64_1.dll. This caused exact-name discovery to report the newly released library as missing in nightly CI.

Prefer the 1.x names while retaining the 0.x names as compatibility fallbacks. Also preload NVRTC when available because cuDSS 1.0 requires it at load time.

Add regression coverage for the supported names and update the 1.8.4 release notes.

Tests: pixi run test (1616 passed, 5 skipped)

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

closes NVIDIA#3180

cuDSS 1.0 changed the Linux SONAME from libcudss.so.0 to
libcudss.so.1 and the Windows DLL name from cudss64_0.dll to
cudss64_1.dll. This caused exact-name discovery to report the newly
released library as missing in nightly CI.

Prefer the 1.x names while retaining the 0.x names as compatibility
fallbacks. Also preload NVRTC when available because cuDSS 1.0 requires
it at load time.

Add regression coverage for the supported names and update the 1.8.4
release notes.

Tests: pixi run test (1616 passed, 5 skipped)
@jpascucci-nv jpascucci-nv self-assigned this Oct 22, 2026
@github-actions github-actions Bot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Oct 22, 2026
@jpascucci-nv jpascucci-nv changed the title pathfinder: support cuDSS 1.0 library names pathfinder: support cuDSS 1.0 library names Oct 22, 2026
@jpascucci-nv
jpascucci-nv requested review from leofang and rwgk October 22, 2026 15:42
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 903fbcc and 4140f76.

📒 Files selected for processing: 3
  • cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py
  • cuda_pathfinder/docs/source/release/1.8.4-notes.rst
  • cuda_pathfinder/tests/test_descriptor_catalog.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added support for recognizing cuDSS 1.0 library names on Linux and Windows, while retaining support for cuDSS 0.x names.
    • NVRTC is now loaded when available alongside cuDSS, supporting environments where it is an optional dependency.

The cuDSS descriptor now recognizes cuDSS 1.0 library names on Linux and Windows, retains 0.x names, and lists NVRTC as an optional dependency. A catalog test checks the library names and dependency metadata. Release notes document these changes.

Changes: cuDSS library metadata

Layer / File(s) Summary
Descriptor metadata and validation
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py, cuda_pathfinder/tests/test_descriptor_catalog.py, cuda_pathfinder/docs/source/release/1.8.4-notes.rst
The descriptor adds cuDSS 1.0 library names and optional NVRTC. The test checks the library names and dependency metadata. The release notes document the changes.

Assessment against linked issues

Objective Addressed Explanation
Restore healthy nightly optional-deps scheduled CI runs [#3180] ❓ The issue does not identify the failure cause, so it is unclear whether these cuDSS descriptor changes resolve it.

Suggested reviewers: cpcloud

Priority: ➖ Normal

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1b6b1

Merge Risk: ⚪ Minimal · up to 1b6b1

The cuDSS naming and optional NVRTC updates are ready to merge with normal checks.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jpascucci-nv jpascucci-nv added the CI/CD CI/CD infrastructure label Oct 22, 2026

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpascucci-nv!

Comment thread cuda_pathfinder/tests/test_descriptor_catalog.py Outdated
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@jpascucci-nv
jpascucci-nv merged commit c968fcc into NVIDIA:main Oct 22, 2026
215 of 219 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2026
Removed preview folders for the following PRs:
- PR #3184
- PR #3188
- PR #3190
Andy-Jost added a commit to somtri/cuda-python that referenced this pull request Oct 23, 2026
…1.0 library names)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Andy-Jost added a commit to fedonman/cuda-python that referenced this pull request Oct 23, 2026
…(cuDSS 1.0 library names)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Andy-Jost added a commit to waterWang/cuda-python that referenced this pull request Oct 23, 2026
…(cuDSS 1.0 library names)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Andy-Jost added a commit to 0z5a/cuda-python that referenced this pull request Oct 23, 2026
…DIA#3188 (cuDSS 1.0 library names)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.pathfinder Everything related to the cuda.pathfinder module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI failure] CI: Nightly optional-deps scheduled runs

2 participants