Repository navigation
Accept zero BAR size for integrated GPUs in cuFile test - #3169
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
Contributor
|
rwgk
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3167.
Use
CU_DEVICE_ATTRIBUTE_INTEGRATEDinstead of the Tegra model-name helper to determine the minimum expected BAR size intest_get_bar_size_in_kb.GB10 is an integrated GPU and successfully reports zero BAR size, but
get_tegra_kind()does not recognize it. The existing test therefore incorrectly requires a positive size.The test still runs on GB10 and asserts an integer, nonnegative result. Discrete GPUs still require a positive BAR size. The device-attribute query must return
CUDA_SUCCESS; existing cuFile error handling is unchanged. No production binding or CI workflow changes.This is separate from #2299, which concerned cuFile error-status handling on GH200 rather than rejecting a successfully returned zero.
Validation
pytest -v -rs cuda_bindings/tests/test_cufile.py::test_get_bar_size_in_kb: 1 passed on an NVIDIA A30 (discrete GPU), driver 595.84.git diff --checkpassed.cuda-bindings 13.4.2.dev243+gf9de5797ewheel environment. No new source build or GB10 rerun for this public branch; integrated behavior was checked with mocks locally.thread_unsafe-marker warnings were emitted by the local environment, which lacks pytest-run-parallel.Checklist