Repository navigation
Exclude Cython-generated .cpp files from wheels - #1578
Merged
Merged
Conversation
Use cythonize build_dir parameter to place generated .cpp files in build/cython/ instead of the source tree. This prevents them from being included in the wheel. Additionally, add exclude-package-data for *.cpp in cuda-bindings to exclude any remaining .cpp files from the package.
Contributor
Contributor
Author
|
/ok to test 15cc9f5 |
Andy-Jost
requested review from
leofang and
mdboom
and removed request for
leofang
February 5, 2026 18:51
cpcloud
approved these changes
Feb 5, 2026
| return cythonize( | ||
| extensions, | ||
| nthreads=nthreads, | ||
| build_dir="build/cython", |
Contributor
There was a problem hiding this comment.
Is this required to avoid including the source?
Contributor
Author
There was a problem hiding this comment.
Yes, this places generated .cpp files outside of the source tree
Andy-Jost
added
cuda.bindings
Contributor
Author
|
/ok to test 15cc9f5 |
mdboom
approved these changes
Feb 5, 2026
This comment has been minimized.
This comment has been minimized.
Andy-Jost
enabled auto-merge (squash)
February 5, 2026 19:12
This comment has been minimized.
This comment has been minimized.
1 task done
Contributor
|
Collaborator
|
We need to backport this to branch 12.9.x as well. |
kkraus14
added
the
to-be-backported
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1578-to-12.9.x origin/12.9.x
cd .worktree/backport-1578-to-12.9.x
git switch --create backport-1578-to-12.9.x
git cherry-pick -x eec6988faf9c0129f327f6da16f42b6b5aee4b60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cython-generated
.cppfiles were being included in the wheels, consuming significant space without providing value to users (they have the compiled binaries already).This PR:
build_dirparameter to place generated.cppfiles inbuild/cython/instead of the source treeexclude-package-datafor*.cppin cuda-bindings to exclude any remaining.cppfilesSize Reduction
Installed Package Size (uncompressed)
Wheel Size (compressed)
Test Plan
.cppfiles