Skip to content

Ensure for 3rd-party imports we only import packages and modules #637

Closed as not planned
Closed as not planned
Ensure for 3rd-party imports we only import packages and modules#637
Labels
P1Medium priority - Should docuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvements
Milestone
cuda.bindings backlog

Description

@leofang
leofang
opened on May 14, 2025

I think we should just import pywintypes and then use it explicitly like except pywintypes.error as e:. I agree it is very unclear (and I did not know error is a legit exception type).

Originally posted by @leofang in #625 (comment)

I like Google's Python style guide on this part:
https://google.github.io/styleguide/pyguide.html#22-imports

Use import statements for packages and modules only, not for individual types, classes, or functions.

Activity

  1. github-actions
    added
    triageNeeds the team's attention
    on May 14, 2025
  2. leofang
    added
    enhancementAny code-related improvements
    P1Medium priority - Should do
    cuda.bindingsEverything related to the cuda.bindings module
    cuda.coreEverything related to the cuda.core module
    on May 14, 2025
  3. rwgk
    self-assigned this
    on May 14, 2025
  4. rparolin
    added this to the cuda-python parking lot milestone on Oct 13, 2025
  5. rparolin
    removed
    triageNeeds the team's attention
    on Jan 19, 2026
  6. rwgk
    removed their assignment
    on Mar 24, 2026

  7. rwgk commented on Mar 24, 2026

    @rwgk
    rwgk
    on Mar 24, 2026
    Contributor

    I unassigned myself: is this issue still relevant, in a coding agent world?

    @cpcloud for visibility

  8. cpcloud commented on Mar 24, 2026

    @cpcloud
    cpcloud
    on Mar 24, 2026
    Contributor

    Feels overly restrictive and unnecessary but also someone probably needs to care about this to make it happen. I'll close it.

  9. cpcloud
    closed this as not plannedon Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Medium priority - Should docuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvements

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions