Repository navigation
feat(services): publish authoritative application origins - #4956
Draft
TaylorMutch wants to merge 1 commit into
Draft
TaylorMutch wants to merge 1 commit into
TaylorMutch wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4956.docs.buildwithfern.com/openshell |
This was referenced Oct 26, 2026
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 27, 2026 03:15
a6d0833 to
e6e1927
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
2 times, most recently
from
October 27, 2026 05:42
932643d to
6c83b66
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 27, 2026 05:42
e6e1927 to
2574b9a
Compare
This was referenced Oct 27, 2026
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 06:24
6c83b66 to
755e4d1
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
2 times, most recently
from
October 27, 2026 06:25
70e365e to
30cf9ce
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
2 times, most recently
from
October 27, 2026 06:46
0944ea2 to
8504067
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 27, 2026 06:46
30cf9ce to
6b2fe9c
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 21:06
8504067 to
feac6b4
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
2 times, most recently
from
October 28, 2026 17:05
dae4a9d to
66220a7
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
2 times, most recently
from
October 28, 2026 22:52
0939a70 to
cf5448a
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 28, 2026 22:52
66220a7 to
3dc01d7
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 29, 2026 01:16
cf5448a to
d43f1ae
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 29, 2026 01:16
3dc01d7 to
29befcd
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 30, 2026 17:57
d43f1ae to
b8e0f49
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
2 times, most recently
from
October 30, 2026 18:13
b71991c to
ad8be4d
Compare
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
October 30, 2026 21:11
ad8be4d to
52300c8
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 30, 2026 21:11
b8e0f49 to
088c1c3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish authoritative application URLs from the configured supervisor application origin, independently of the gateway API origin. Return explicit application and gateway URLs so clients can choose an access path.
Based on main at
d7b616895. Stacked onfeat/4667-service-discovery/TaylorMutch.Related Issue
Closes #4953. Part of RFC 0017.
Changes
Integrator perspective
The service API tells clients which public URL to use; discovery tells routers where to send requests.
public_urlfor your public ingress. Responses exposeapplication_url, the existinggateway_url, and a preferredurlthat selects the application URL when configured.Publishing a URL does not create DNS or ingress resources, or establish reachability. Both ingress paths use
[openshell.gateway].service_hostname_format; the app listener has no separate naming mode. Keeping the installation name and public HTTPS domain/port unchanged preserves the service URL when switching ingress.Public URL selection
This PR publishes the configured application origin alongside the existing gateway-mediated URL. The example uses gateway installation
gateway-a, workspacedefault, sandboxmy-sandbox, and serviceweb.flowchart TD I["Service identity<br/>gateway-a / default / my-sandbox / web"] M["One gateway setting: service_hostname_format<br/>readable or hashed"] I --> L["Shared service label generator<br/>Hashed example: enh47uqyj7bpyttz"] M --> L L --> G["gateway_url<br/>https://enh47uqyj7bpyttz.gateway.example.com/"] L --> A["application_url<br/>https://enh47uqyj7bpyttz.apps.example.com/"] O["Configured application public origin<br/>https://apps.example.com"] --> A A -->|"Preferred when configured"| U["url returned to clients"] G -->|"Fallback when application_url is absent"| UHashed mode is shown above. Readable mode uses
<workspace>--<sandbox>[--<service>]for both paths. The two access paths are alternatives; when their public origins match, their complete URLs match. Integrators consume discovery hostnames as returned.Connecting the published URL to a sandbox
The proxy and example controller below are alternative discovery consumers, shown for context. This PR publishes URLs; it does not deploy either integration. Dashed arrows configure routing; solid arrows carry application traffic.
flowchart TD API["Service API<br/>Returns public application URL"] -.->|"URL used by client"| Client["Application client"] D["Discovery API<br/>Exact hostname → current supervisor Pod IP:port<br/>Installation identity and expiry"] D -.->|"Snapshots / watches"| P["Sandbox proxy<br/>TLS passthrough"] D -.->|"Snapshots / watches"| C["Example Kubernetes HTTPRoute controller<br/>Separate POC"] C -.->|"Reconciles HTTPRoutes, backend resources<br/>and backend TLS configuration"| K["Kubernetes Gateway<br/>Edge TLS termination"] Client -->|"Option A: HTTPS to published hostname"| P Client -->|"Option B: HTTPS to published hostname"| K P -->|"Application TLS forwarded unchanged"| S["Owning supervisor<br/>Application TLS listener"] K -->|"HTTPS to discovered endpoint<br/>Preserve application Host and backend SNI"| S S --> W["Declared service inside sandbox"]Both paths keep application traffic out of the OpenShell gateway. The integrator provides DNS, certificates, and ingress configuration; discovery supplies backend changes and withdrawal/expiry information.
Release Notes
Testing
Live Kubernetes validation preceded integration of the latest listener hardening;
focused Rust regressions validate that final integration. New-head CI is pending.
Qualification limits
Live HA validation exercised supervisor process/Pod loss on a local k3d cluster. Whole-node failure, real network partitions, metric-driven HPA, sustained production load, and published release artifacts remain unqualified. Grant-file projection contributes to revocation propagation time. Both ingress paths now share the gateway hostname format and label generator. The same installation identity and public HTTPS domain/port preserve service URLs when switching ingress. Installation-status presentation (#4670) remains separate work. Live Kubernetes runs above preceded hostname integration; the naming and shutdown-fence integration is validated by focused Rust regressions.
The example Kubernetes HTTPRoute controller is a deferred compatibility POC outside this stack.
Checklist
PR dependency order: #4936 → #4940 → #4941 → #4956 → #4963 → #4964 → #4957 → #4958.