Repository navigation
ci(release): reuse the promoted prerelease's release notes preview - #4754
Merged
matthewgrossman merged 3 commits intoOct 20, 2026
Merged
Conversation
Stable releases now publish the selected prerelease's release-notes artifact with the prerelease tag replaced by the stable tag. Release falls back to generating notes when the preview is missing, expired, or malformed, or when dispatched with regenerate-notes=true. The selection script exposes the qualified Pre-release run ID for the download. Closes #4753 Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4754.docs.buildwithfern.com/openshell |
Download and retag the preview in Select Qualified Prerelease, which already knows the qualified Pre-release run, instead of a separate job. Drop the regenerate-notes input and preview format checks. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
marked this pull request as ready for review
October 20, 2026 17:44
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 20, 2026 17:44
3 of 6 tasks
TaylorMutch
approved these changes
Oct 20, 2026
matthewgrossman
deleted the
ci/4753-reuse-release-notes/matthewgrossman
branch
October 20, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stable releases now publish the release notes preview from the promoted pre-release, retagged to the stable version, so the notes reviewed before release are the notes that ship. When the preview is missing or expired, Release generates notes as before.
Related Issue
Closes #4753
Changes
select-release-candidate.pyalso returnsqualification_run_id, the Pre-release run it already selects.Select Qualified Prereleasedownloads that run'srelease-notesartifact withgh run download, replaces the pre-release tag with the stable tag, and uploads it as this run'srelease-notesartifact. Its summary says whether notes were reused or will be regenerated.release.ymlpasses the result torelease-publish.ymlas the internalrelease-notes-reusedcall input (not a dispatch input), which skipsWrite Release Noteswhen true. Pre-release andnotes-onlypreviews are unchanged.CI.mdand thewatch-github-actionsskill.Follow-ups:
release-captainskill (on another unmerged branch) should describe the reuse once both land.regenerate-notesdispatch input could be added later if that becomes common.Release Notes
Testing
actionlint -shellcheck= -pyflakes=onrelease.ymlandrelease-publish.yml: the only error is the existingconcurrency.queuekey, also reported onmain.zizmor --offline: same findings asmain(12 low, 1 informational, 17 suppressed).shellcheckon the extracted notes step.ubuntu:24.04container (GNU sed) against the realv0.1.5-pre.7preview from run 39423830966: only the heading and install command changed, tov0.1.5. A missing artifact leavesreusedunset and writes the regeneration summary.pre.1retagging leavespre.10untouched.gh run downloadexits non-zero for a missing artifact.ruff check/ruff format --checkonselect-release-candidate.py(no existing tests for this script).Checklist