Repository navigation
fix(network): bind hostname policy to supervisor DNS - #4602
Conversation
Signed-off-by: Adrien Langou <alangou@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-4602.docs.buildwithfern.com/openshell |
|
Label |
|
/ok to test 48da2fe |
Compatibility review (advisory)Unaddressed breaking changes Existing Linux policies that rely on sandbox 1. policy — NOT ACKEDHostname-authorized endpoints previously resolved through sandbox
Review details
Advisory review; publication gates are unchanged. |
PR Review StatusThe independent code review found no blocking findings. Hostname-authorized destinations now use the supervisor resolver, while sandbox aliases remain available behind an independently checked IP allowlist or trusted gateway pin. The published docs and policy skill explain the changed requirements. Branch Checks and E2E are running on the current head; Gator will monitor their results. Blocking findings: None. Carried findings: None. Non-blocking suggestions: None. Gator metadata
|
|
Acknowledged. This security fix intentionally changes resolution for sandbox-only host aliases without an independent IP constraint. Driver-managed host-gateway aliases remain supported through the trusted runtime pin. Custom aliases should add a narrow allowed_ips. I accept this compatibility tradeoff. |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: Gator had reached I removed the active Gator metadata
|
Summary
Bind hostname-based network policy to supervisor-controlled DNS while preserving sandbox host aliases for independently IP-constrained destinations.
Related Issue
Tracked through the private security review process.
Changes
Testing
Validated with the full
openshell-supervisor-networktest suite, targeted regression coverage, Clippy, rustfmt, docs validation, and the Docker corporate-proxy E2E suite.Checklist