Skip to content

fix(server): send Accept json on OAuth token refresh - #4530

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/4356-github-app-token-refresh/ericcurtin
Oct 15, 2026
Merged

johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/4356-github-app-token-refresh/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

GitHub App token refresh fails because GitHub answers form-encoded unless asked for JSON. Send Accept: application/json.

Related Issue

Closes #4356

Changes

  • Add the Accept header in request_token.
  • Add a unit test that only matches when the header is present.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Ran cargo fmt --check, cargo clippy -p openshell-server --all-targets -- -D warnings, and cargo test -p openshell-server --lib provider_refresh.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@mrunalp @derekwaynecarr PTAL, and /ok to test b55cbfdc9f5e39fcb6ebcf11bb076ad4e51d2373 if it looks good. Thank you!

@mrunalp

mrunalp commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

/ok to test b55cbfd

@mrunalp mrunalp added the test:e2e Requires end-to-end coverage label Oct 14, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for b55cbfd. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@johntmyers
johntmyers enabled auto-merge October 15, 2026 15:16
@johntmyers
johntmyers added this pull request to the merge queue Oct 15, 2026
Merged via the queue into NVIDIA:main with commit 2804f68 Oct 15, 2026
153 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow use of GitHub App access tokens

4 participants