Repository navigation
fix(server): send Accept json on OAuth token refresh - #4530
Merged
johntmyers merged 1 commit intoOct 15, 2026
Merged
johntmyers merged 1 commit into
johntmyers merged 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@mrunalp @derekwaynecarr PTAL, and |
Collaborator
|
/ok to test b55cbfd |
|
Label |
freeqaz-openai
approved these changes
Oct 14, 2026
mrunalp
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub App token refresh fails because GitHub answers form-encoded unless asked for JSON. Send
Accept: application/json.Related Issue
Closes #4356
Changes
Acceptheader inrequest_token.Testing
Ran
cargo fmt --check,cargo clippy -p openshell-server --all-targets -- -D warnings, andcargo test -p openshell-server --lib provider_refresh.Checklist