Repository navigation
fix(server): install the metrics recorder before startup reconciliation - #4524
Merged
pimlock merged 1 commit intoOct 16, 2026
Merged
Conversation
The endpoint-status startup sweep ran before the gateway installed its Prometheus recorder, so the lock waits, timeouts, errors and hold times it recorded went to the no-op recorder and only its warnings reached the log. The sweep retries lock timeouts for up to three lock waits before startup fails, and a slow sweep that still succeeds is what operators want to see in the lock metrics. When metrics are enabled, the recorder is now installed before startup reconciliation, and the metrics listener still binds with the other listeners. A new pod's first scrape therefore already holds the sweep's samples, so they show in the raw counter and histogram count values, not in rate() or increase(). A sweep that fails still exits before any listener binds, so its timeouts remain log-only. The startup lock-timeout test now waits for the sweep's timeout counter instead of a fixed sleep and checks its timeout and wait samples, and the debug skill says which startup timeouts reach the metrics and how to read them. Part of NVIDIA#4307 Closes NVIDIA#4523 Signed-off-by: Emilien Macchi <emacchi@redhat.com>
Collaborator
|
/ok to test 6a3ca1e |
|
Label |
Collaborator
|
LG to me |
Collaborator
|
/ok to test 6a3ca1e |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
/ok to test 6a3ca1e |
pimlock
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The endpoint-status startup sweep ran before the gateway installed its Prometheus recorder, so the mutation-lock waits and timeouts it recorded were dropped. The recorder is now installed before startup reconciliation, so a sweep that succeeds shows up in the lock metrics.
Related Issue
Closes #4523 (needs
state:acceptedfor the issue acceptance check)Part of #4307
Changes
run_serverinstalls the recorder before startup reconciliation, still only whenmetrics_bind_addressis set. The metrics listener binds where it did._countvalues, not inrate()orincrease(). A sweep that fails still exits before any listener binds, so its timeouts stay log-only.backfill_legacy_policy_historyat the same spot. Keep both, with the recorder install first.Testing
mise run rust:lint,rust:format:check,license:checkandmarkdown:lintpass.cargo test -p openshell-server --features test-supportpasses, and the sweep tests passed 5 runs in a row.run_serverhas no test harness, so no test here fails on main.Checklist