Repository navigation
fix(deps): scope rcgen's x509-parser feature to the supervisor - #4468
Merged
TaylorMutch merged 1 commit intoOct 14, 2026
Merged
TaylorMutch merged 1 commit into
TaylorMutch merged 1 commit into
Conversation
rcgen 0.13.2 declares its optional x509-parser dependency with the verify feature, which pulls in ring. The workspace enabled rcgen's x509-parser feature for every crate, so the CLI and gateway linked ring alongside aws-lc even though nothing in them verifies signatures with x509-parser. Only SandboxCa::from_pem in openshell-supervisor-network needs CertificateParams::from_ca_cert_pem. Enable the feature there alone. ring no longer appears in the dependency trees of openshell, openshell-gateway or openshell-prover; it remains in openshell-supervisor until rcgen is upgraded. Release builds compile one package at a time, so the feature does not leak into the other binaries. Signed-off-by: politerealism <burdcat17@gmail.com>
politerealism
marked this pull request as ready for review
October 14, 2026 16:33
Collaborator
|
/ok to test 9c98b32 |
1 similar comment
Collaborator
|
/ok to test 9c98b32 |
TaylorMutch
approved these changes
Oct 14, 2026
2 of 37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rcgen0.13.2 declares its optionalx509-parserdependency with theverifyfeature, which pulls inring. The workspace enabledrcgen'sx509-parserfeature for every crate, so the CLI and gateway linkedringnext to aws-lc even though nothing in them verifies signatures withx509-parser. This keeps the feature only where it is used.Related Issue
Contributes to #3510
Changes
Cargo.toml: drop"x509-parser"from the workspacercgenfeatures.crates/openshell-supervisor-network/Cargo.toml: enable it there.SandboxCa::from_pemcallsCertificateParams::from_ca_cert_pem, the only use in the repo.cargo tree -e normal -i ring(x86_64 Linux,--locked):openshellringopenshell-gatewayringopenshell-proveropenshell-supervisorringringCargo.lockis unchanged. The supervisor still linksringuntilrcgenis upgraded to 0.14, which no longer forcesverifybut is a breaking API change across about ten crates. Release builds compile one package at a time (cargo build --package ... --bin ...), so the feature does not leak into the other binaries; a--workspacebuild still unifies it.Testing
cargo metadata --lockedsucceeds, so the lockfile is consistent.cargo clippy -D warnings --all-targetspasses foropenshell-supervisor-network,openshell-gateway,openshell-cli,openshell-bootstrapandopenshell-server.cargo test --libpasses foropenshell-supervisor-network(1553),openshell-bootstrap(64), and thecertgen,multiplexandsandbox_jwttests inopenshell-server(90).cargo fmt --all -- --checkpasses.openshell-servertest suite and e2e.Checklist