Repository navigation
Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 12, 2026 14:25
|
🌿 Preview your docs: https://nvidia-preview-pr-4424.docs.buildwithfern.com/openshell |
|
Label |
6 tasks done
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
codex/e2e-conformance-only/el
branch
from
October 12, 2026 17:55
4450756 to
930f026
Compare
This was referenced Oct 12, 2026
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
enabled auto-merge
October 12, 2026 20:33
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the default Rust E2E coverage when CI exports an empty feature override, and use
e2e-conformance-onlyfor intentional conformance-only runs. Temporarily exclude onlycanonical_main_connect_recovers_its_ssh_transportin the Kubernetes nextest profile while #4445 investigates input-owner cleanup after reconnect. Keep the existing Kubernetes port-forward transport and the test's coverage on other drivers.The empty-feature behavior underlying this CI coverage gap was introduced by #2925, merged on September 1, 2026. That PR changed the runners from
${VAR:-default}to${VAR-default}and made an empty feature list skip Rust E2E tests after conformance. #2260, merged on September 7, then wired the Kubernetes workflow's empty default feature input into that override. Together, these changes caused the default Kubernetes lane to run conformance only while reporting success.Related Issue
No separate implementation issue is required for this localized CI fix, which does not change product behavior or public APIs. The missed coverage is visible in this Kubernetes job.
Temporary Kubernetes-only test waiver: #4445. This PR does not close the investigation.
Changes
e2e-conformance-onlyin the Docker, Podman, Kubernetes, and VM runners and consume it before invoking Cargo.profile.e2e-kubernetes. Keep the other 96 restored default Kubernetes tests enabled, along with recovery coverage on other driver profiles.TESTING.md; update workflow input help. No kind configuration, Service type, or gateway transport changes are included.Testing
mise run pre-commiton the final branch.e2e-kubernetes; a similarly named neighbor and an ordinary lifecycle test remain selected. The recovery name is selected under bothcianddefaultprofiles.git diff --check.mise run ci: the earlier attempt with fresh Go caches hit Rust test linking because system Z3 is unavailable (ld: library 'z3' not found).Checklist