Skip to content

test(podman): install util-linux-script in the e2e guest - #4423

Open
politerealism wants to merge 1 commit into
NVIDIA:mainfrom
politerealism:test/3712-install-script-in-podman-e2e-guest/politerealism
Open

politerealism wants to merge 1 commit into
NVIDIA:mainfrom
politerealism:test/3712-install-script-in-podman-e2e-guest/politerealism

Conversation

@politerealism

Copy link
Copy Markdown
Contributor

Summary

Install util-linux-script in the rootless tmachine guest before the e2e-podman archive runs, and stop excluding sandbox_lifecycle. Four of its tests attach a PTY to openshell sandbox create through openshell_tty_cmd, which spawns script; the Fedora guest does not provide it, so those tests failed to start.

Related Issue

Contributes to #3712

Changes

  • tests/ansible/playbooks/drivers/podman/e2e.yaml: add a task that installs util-linux-script (the Fedora package that provides script) before the archive tests run.
  • tests/artifacts.nix: remove sandbox_lifecycle and its comment from podmanE2eFollowUpBinaries.

The package comes from the distro repository when the playbook runs, the same way setup already downloads other tools. Moving it into the guest image build would be a possible follow-up if we want no network use after setup.

Testing

  • Evidence from the probe PR (draft test(podman): probe lifted e2e exclusions in the tmachine guest (do not merge) #4386, not for merge). Without the package, four tests failed with spawn openshell sandbox create: No such file or directory: canonical_main_exit_zero_completes_persistent_sandbox, canonical_main_nonzero_exit_preserves_status, sandbox_create_with_no_keep_cleans_up_after_tty_command, sandbox_create_with_no_keep_preserves_failure_then_cleans_up. With the package installed (run 38246241655) all 19 sandbox_lifecycle tests passed in the rootless Fedora guest.
  • ansible-playbook --syntax-check on the playbook and nix-instantiate --parse tests/artifacts.nix succeed.
  • Not yet run on this PR's own CI. The test:e2e label and a re-run are needed to run the e2e-podman archive.
  • Not covered: one run with the package, and the rootful guest (the e2e-podman archive runs rootless only).

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): not applicable

@copy-pr-bot

copy-pr-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elezar elezar added the test:e2e Requires end-to-end coverage label Oct 12, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/4423 does not exist yet. A maintainer needs to comment /ok to test e2bd2a02726354eae6f8aa60ac581b1c956f37d5 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@elezar

elezar commented Oct 12, 2026

Copy link
Copy Markdown
Member

/ok-to-test e2bd2a0

The e2e tests that attach a PTY to sandbox create spawn the script command through openshell_tty_cmd, which the Fedora guest does not provide, so four sandbox_lifecycle tests failed to spawn it. Install util-linux-script before the archive runs and stop excluding sandbox_lifecycle. With the package installed all 19 sandbox_lifecycle tests passed in the rootless guest. Contributes to NVIDIA#3712.

Signed-off-by: politerealism <burdcat17@gmail.com>
@politerealism
politerealism force-pushed the test/3712-install-script-in-podman-e2e-guest/politerealism branch from e2bd2a0 to 4fd8865 Compare October 15, 2026 19:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants