Skip to content

fix(windows): restore MSVC lint for CLI and MXC - #4194

Open
feloy wants to merge 2 commits into
NVIDIA:mainfrom
feloy:fix-4190/windows-clippy
Open

feloy wants to merge 2 commits into
NVIDIA:mainfrom
feloy:fix-4190/windows-clippy

Conversation

@feloy

@feloy feloy commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Restore Windows MSVC lint by handling Unix-only SSH cancellation signatures in Clippy and updating the MXC mocked-backend constructor call. These changes keep runtime behavior unchanged.

Related Issue

Closes #4190
Closes #4191

Changes

  • Scope three Clippy allowances to non-Unix builds where signal handling is compiled out.
  • Pass the default gateway name when constructing the mocked MXC backend in tests.

Testing

  • Checks appropriate to the affected code and behavior pass:
    • mise run --skip-tools windows:lint:x64 passed on a local Windows machine (reported by the PR author).
    • cargo fmt --all -- --check passed on macOS.
    • cargo clippy -p openshell-cli --all-targets -- -D warnings passed on macOS.
    • Repository commit hooks passed for both commits, including workspace Rust lint.
  • Unit tests added/updated (not applicable: these are lint and test-target compilation fixes).
  • E2E tests added/updated (not applicable).
  • Windows ARM64 lint and tests have not been run.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Architecture docs updated (not applicable; no architecture or user-facing behavior changed).

feloy added 2 commits October 5, 2026 10:23
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Refs NVIDIA#4191

Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy
feloy requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners October 5, 2026 08:54
@copy-pr-bot

copy-pr-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@feloy

feloy commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Needs the test:windows label

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(driver-mxc): test helper fails to compile after gateway-name argument bug: Windows MSVC lint fails in CLI SSH cancellation

1 participant