Repository navigation
feat(docker): support host and bridge supervisor networking - #4016
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
d633562 to
16bad48
Compare
|
🌿 Preview your docs: https://nvidia-preview-pr-4016.docs.buildwithfern.com/openshell |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
9e2288b to
8f122f7
Compare
|
Label |
TaylorMutch
left a comment
There was a problem hiding this comment.
One non-blocking telemetry concern: bridge mode changes the reachability of loopback OTLP endpoints. This can be addressed here or in a separate follow-up fix if preferred.
I reviewed the full diff and surrounding code and verified the host-gateway alias mapping in a temporary Docker Desktop bridge container. I did not run the full test suite or validate ECI itself.
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Since #4016, host e2e runs omit the Docker driver's grpc_endpoint and let the driver discover the gateway. The HTTP session hook test required the key and panicked. Fall back to loopback, which the host-networked supervisor shares with the gateway, and read the key only from the Docker driver table. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Summary
The Docker supervisor previously required host networking. Add an operator-owned
supervisor_network_modesetting so deployments can explicitly use host or bridge networking. Host remains the default, andautoselects host.Bridge callbacks preserve explicit endpoints and TLS verification. Docker's actual host address is discovered automatically once when the driver starts, so Desktop deployments do not confuse the VM's bridge gateway with the host. All runtime changes are confined to the Docker driver; the supervisor is unchanged.
Related Issue
Related to #4015. Automatic ECI mode selection and ECI sandbox-runtime compatibility remain outside this PR's scope.
Changes
network=noneand the existing isolation requirements for workloads.host.docker.internal, resolve Docker'shost-gatewayonce during driver construction and cache the IP for all sandbox launches.--help, wait for exit, and download Docker's generated/etc/hoststhrough the archive endpoint. No shell ordocker execis used.host_gateway_ipremains an optional override that skips discovery.Validation
192.168.65.254and verified no resolver container remained after either successful discovery or a deliberately failed container start.