Repository navigation
fix(supervisor-network): bound OPA policy load diagnostics - #3369
Conversation
Report fixed validation categories with item and byte limits, preserving safe YAML positions while discarding authored payloads and error chains. Keep rejected L7 warnings out of diagnostics and cover load/reload paths, omission behavior, and active-state retention with regression tests. Align the parity fixture with the Debian supervisor base and separate sandbox runtime image so current runtime validation has complete inputs. Refs: NVIDIA#3092 Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This change is scoped to the accepted policy-validation work in #3092. The initial code review found no blocking defects: policy-load diagnostics are bounded and redacted, rejected reloads retain active state, and the direct operator-facing diagnostic contract is documented.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Partially implements accepted issue #3092 with a focused policy-diagnostic and rejected-reload change.
- Docs: Fern policy reference and architecture documentation are updated.
- Checks: Branch Checks, Helm Lint, and Trivy Changes are green on the current head; the required E2E rerun is queued.
- E2E:
test:e2eapplied; E2E Label Help required rerunning current-head run 35070313194, and the new attempt is queued. - Head SHA:
e5f606fdd36a92779d1ce3441a6d238e92c89840 - Base SHA:
b3e4ad4579e24dacfb285924876473b50a04b988 - Merge base SHA:
b3e4ad4579e24dacfb285924876473b50a04b988 - Patch ID:
7272c436d91eed928257c7bba3dd1f6511d699ad - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Merge upstream main and preserve the bounded OPA diagnostic contract alongside the canonical policy parser documentation. Adopt the upstream parity fixture, including sandbox runtime environment isolation. Signed-off-by: Shiju <shiju@nvidia.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The follow-up review found no blocking defects. The original bounded-diagnostics patch remains patch-identical after merging main, and the author-owned documentation resolution preserves both the canonical parser contract and the previously reviewed policy-load diagnostic boundary.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Gator metadata
- Validation: Partially implements accepted issue #3092 with a focused policy-diagnostic and rejected-reload change.
- Docs: Fern policy reference and architecture documentation remain updated after the merge resolution.
- Checks: Current-head Branch Checks and E2E are queued or running; Helm Lint and Trivy Changes are green.
- E2E:
test:e2eis applied and current-head run 35178560069 is queued. - Head SHA:
33bd9c9916bbb72a724ab20e4404f9da9d913b15 - Base SHA:
2ccef97769e0e39c4dc06b4c3953d3735814f146 - Merge base SHA:
2ccef97769e0e39c4dc06b4c3953d3735814f146 - Patch ID:
169d8fedf79631da6d3d5eb3a338fa43e6f8c222 - Gator payload:
9 - Review mode:
follow_up - Previous reviewed SHA:
e5f606fdd36a92779d1ce3441a6d238e92c89840 - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The PR reached I removed the active Gator metadata
|
Summary
Bound the diagnostics returned when the OPA engine rejects a policy load or reload. Report fixed validation categories instead of authored names, values, paths or nested error text, with at most eight items and 512 UTF-8 bytes per message. Preserve safe YAML source positions and active state when candidate validation rejects a reload.
Related Issue
Partially addresses accepted #3092: bounded policy-load diagnostics.
Changes
Testing
mise run pre-commitpassesChecklist