Skip to content

chore(deps): replace serde_yml with noyalib - #3031

Merged
elezar merged 2 commits into
mainfrom
chore/2018-modernize-yaml-parser/elezar
Sep 7, 2026
Merged

elezar merged 2 commits into
mainfrom
chore/2018-modernize-yaml-parser/elezar

Conversation

@elezar

@elezar elezar commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Summary

Replace direct serde_yml usage with a noyalib compatibility alias across the root workspace, Rust e2e harness, and governance interceptor example. This removes the direct libyml dependency that backs Dependabot alerts 1, 8, and 11 while keeping existing serde_yml:: call sites mostly stable.

Related Issue

Refs #2018

Addresses GitHub Dependabot security alerts for libyml via serde_yml 0.0.12:

This does not close #2018 because the separate kube-client serde_yaml / unsafe-libyaml path remains out of scope.

Changes

  • Switched direct serde_yml dependency declarations to noyalib 0.0.28 with compat-serde-yaml.
  • Regenerated root, e2e, and governance example lockfiles, removing libyml from all three graphs.
  • Adjusted the governance interceptor profile loader for noyalib mapping/from-value API differences.

Testing

  • mise run pre-commit passes
  • dev-openshell shell mise run pre-commit attempted; failed in existing helm:lint because chart metadata is missing postgresql
  • cargo tree -i libyml no longer finds the package in root, e2e, or governance example graphs
  • dev-openshell shell mise exec -- cargo check --all-targets -p openshell-policy -p openshell-prover -p openshell-providers -p openshell-router -p openshell-supervisor-network -p openshell-cli -p openshell-driver-mxc
  • dev-openshell shell mise exec -- cargo check --manifest-path e2e/rust/Cargo.toml --all-targets --all-features
  • dev-openshell shell mise exec -- cargo check --manifest-path examples/governance-interceptor/Cargo.toml --all-targets
  • dev-openshell shell mise exec -- cargo test -p openshell-policy -p openshell-providers -p openshell-router -p openshell-prover
  • dev-openshell shell mise exec -- cargo test -p openshell-supervisor-network opa
  • dev-openshell shell mise exec -- cargo test -p openshell-cli output
  • dev-openshell shell mise exec -- cargo test -p openshell-driver-mxc policy_mapper_matrix
  • Focused Clippy passed for root YAML users, governance example, and e2e GPU target
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar
elezar requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 31, 2026 12:16
@elezar elezar added the test:e2e Requires end-to-end coverage label Aug 31, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for 57b76aa. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

krishicks
krishicks previously approved these changes Aug 31, 2026
mrunalp
mrunalp previously approved these changes Aug 31, 2026
@elezar
elezar force-pushed the chore/2018-modernize-yaml-parser/elezar branch from 57b76aa to 91fc64f Compare September 1, 2026 08:53
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the chore/2018-modernize-yaml-parser/elezar branch from 91fc64f to 4bd99ea Compare September 7, 2026 11:59
@elezar
elezar dismissed stale reviews from mrunalp and krishicks via 4f15c2e September 7, 2026 12:19
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the chore/2018-modernize-yaml-parser/elezar branch from 4f15c2e to f8b73fa Compare September 7, 2026 12:55
@elezar
elezar enabled auto-merge September 7, 2026 12:57
@elezar
elezar added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit e4369ad Sep 7, 2026
75 checks passed
@elezar
elezar deleted the chore/2018-modernize-yaml-parser/elezar branch September 7, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): modernize YAML parser dependencies

4 participants