Repository navigation
feat(cli): forward TRACEPARENT/TRACESTATE to gateway for CI trace continuity #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crm00re
wants to merge
3
commits into
NVIDIA:main
Choose a base branch
from
crm00re:fix2639
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+336
−17
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
GatewayInterceptor::callcomposes auth then trace, andinterceptor_from_tlswiresEnvTraceContextInterceptor::from_envinto it, but no test exercises this composition; thetls.rstests cover only routing and TLS helpers.Why this matters: This is the integration point that makes CLI trace forwarding actually happen. If
trace.callwere dropped or the two interceptors swapped, the feature would silently no-op and no test would catch it.Suggested fix: Add a test that sets both an edge token and a
TRACEPARENT, runs the composed interceptor, and asserts both the auth header and thetraceparentmetadata are present.Source: test-quality agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed with
gateway_interceptor_composes_auth_and_trace_forwarding: it builds the interceptor through the realinterceptor_from_tlswith an OIDC token plusTRACEPARENT/TRACESTATEset, runs the composedcall, and assertsauthorization,traceparent, andtracestateall land in the request metadata — so a dropped or swappedtrace.callnow fails the test.One deviation from the suggestion: the CLI crate is
#![forbid(unsafe_code)], so the test can't callstd::env::set_vardirectly. It sets the env via the crate's existingtemp-envdev-dependency underTEST_ENV_LOCK(the same patterncompleters.rsuses), which adds no new dependencies or public API.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed.
gateway_interceptor_composes_auth_and_trace_forwardingbuilds through the realinterceptor_from_tlsand asserts the auth header plustraceparent/tracestateare all present. Passes locally.