Repository navigation
fix(server): downgrade expected connection teardown errors to debug - #1369
Merged
Merged
Conversation
russellb
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
May 13, 2026 20:17
Collaborator
|
/ok to test 1d988d9 |
Collaborator
|
tests look good, but needs a rebase |
h2 connection errors during sandbox deletion are expected — the supervisor gRPC stream is torn down when the sandbox is removed. Downgrade these from ERROR/WARN to DEBUG so they don't pollute gateway logs during normal operations. Signed-off-by: Russell Bryant <russell.bryant@gmail.com>
russellb
force-pushed
the
fix/server-connection-teardown-logs
branch
from
May 14, 2026 15:34
1d988d9 to
33449bb
Compare
Contributor
Author
thanks! rebase complete |
Collaborator
|
/ok test 33449bb |
drew
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h2 connection errors during sandbox deletion are expected — the supervisor gRPC stream is torn down when the sandbox is removed. Downgrade these from ERROR/WARN to DEBUG so they don't pollute gateway logs during normal operations.
Related Issue
None — discovered during nftables migration e2e testing (#1335).
Changes
is_benign_connection_close()helper inlib.rsthat matches expected h2/connection teardown error messageserror!todebug!for both TLS and plaintext paths when the error matches a benign connection closeForwardTcp: inbound stream failedfromwarn!todebug!ingrpc/sandbox.rs— stream teardown during sandbox deletion is expectedTesting
mise run pre-commitpassesChecklist