Repository navigation
sandbox upload creates a directory instead of a file when source is inside a git repository #1740
Description
What happens
`openshell sandbox upload` creates a directory at the destination path instead of a regular file when the source file lives inside a git repository and the destination basename differs from the source basename. The directory contains the uploaded file under the original source basename.
What should happen
The file should land at the exact destination path with the destination basename, matching cp-style semantics — regardless of whether the source is inside a git repository.
How to reproduce
# Create and detach a sandbox
openshell sandbox create --name my-sandbox -- sleep 300 &
sleep 5
SANDBOX="my-sandbox"
openshell sandbox exec -n "${SANDBOX}" -- mkdir -p /tmp/repro/git-case /tmp/repro/nogit-case
# Case 1 (BUG): source inside a git repository
GITDIR="$(mktemp -d)"
echo '{"hello":"world"}' > "${GITDIR}/source.json"
git -C "${GITDIR}" init -q
git -C "${GITDIR}" add source.json
git -C "${GITDIR}" -c user.email="x@x" -c user.name="x" commit -q -m "init"
openshell sandbox upload "${SANDBOX}" "${GITDIR}/source.json" /tmp/repro/git-case/dest.json
openshell sandbox exec -n "${SANDBOX}" -- ls -la /tmp/repro/git-case/
# dest.json is a directory (BUG)
# Case 2 (OK): source outside any git repository
NOGITDIR="$(mktemp -d)"
echo '{"hello":"world"}' > "${NOGITDIR}/source.json"
openshell sandbox upload "${SANDBOX}" "${NOGITDIR}/source.json" /tmp/repro/nogit-case/dest.json
openshell sandbox exec -n "${SANDBOX}" -- ls -la /tmp/repro/nogit-case/
# dest.json is a regular file (correct)Case 1 — source in git repo (bug):
drwxr-xr-x. 1 sandbox sandbox 22 Jun 4 dest.json
Case 2 — source outside git repo (correct):
-rw-r--r--. 1 sandbox sandbox 18 Jun 4 dest.json
Context
The cp-style fix from #694 corrected this for the non-git upload path. When the source is inside a git repository, the upload routes through git_sync_files, which still uses the old mkdir -p <dest> behavior. PR #1595 bypassed git_sync_files for symlinks but not for regular tracked files.
- openshell version: 0.0.54
- OS: Linux x86_64
Activity
TaylorMutch commentedon Jul 13, 2026
rh-dnagornuks commentedon Jul 15, 2026
Hello, I made a PR against my own fork to fix this issue. Would the changes made there be acceptable upstream? I already submitted a vouch request here.
rh-dnagornuks commentedon Jul 21, 2026
Hi, just wanted to follow up. I still have the fix ready to submit upstream once my vouch request is approved. Let me know if there's anything I should change in the fix. Thank you!
github-actions commentedon Aug 28, 2026
This issue has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. Comment or remove the state:stale label to keep it open.