test: add regression coverage for proxy hostname parser differentials #1498

Activity

1. zredlined

   added

   area:sandboxSandbox runtime and isolation workSandbox runtime and isolation work

   topic:securitySecurity issuesSecurity issues

   topic:testing

   on May 21, 2026
2. zredlined commented on May 21, 2026

   

   zredlined

   on May 21, 2026

   CollaboratorAuthor

   More actions

   🏗️ build-plan

   Implementation Plan

   Issue type: chore
   Complexity: Low
   Confidence: High — clear path

   Summary

   Add focused regression tests for hostname parser/canonicalization edge cases in the sandbox proxy path. The tests should document the parser-differential class from the referenced Claude Code SOCKS5 NUL-byte bypass and verify OpenShell continues to fail closed across policy matching, wildcard hosts, DNS resolution, and SSRF/internal-IP checks.

   Scope

   • crates/openshell-sandbox/src/proxy.rs: add unit tests around CONNECT target parsing and resolver/SSRF helper behavior for malformed or ambiguous hostnames.
   • crates/openshell-sandbox/src/opa.rs: add or extend wildcard-host policy tests for NUL/control/encoded-style hostname inputs, ensuring policy matching does not create an unintended allow path.

   Implementation Steps

   1. Add parser-focused unit tests for CONNECT targets containing NUL/control characters, percent-encoded NUL-like input, empty hosts, and oversized hosts.
   2. Add wildcard policy tests that exercise malformed hostname inputs against *.example.com style rules.
   3. Add resolver/SSRF helper assertions that malformed or ambiguous destinations fail before an upstream connection can be established.
   4. Keep the implementation test-only unless the tests reveal a concrete fail-open behavior that requires a small validation fix.

   Test Plan

   • Unit tests: cargo test -p openshell-sandbox <focused filters> --lib covering proxy parser, OPA wildcard matching, and resolver/SSRF behavior.
   • Integration tests: N/A — this is regression coverage for existing module boundaries.
   • E2E tests: N/A — no sandbox infrastructure or user workflow changes expected.

   Risks & Open Questions

   • If a test exposes permissive behavior in parse_target, decide whether to make this issue include the small fail-closed validation fix or split that into a separate fix ticket. Given the security context, a minimal validation fix would likely be appropriate if needed.

   Documentation Impact

   • None expected. This is internal regression coverage; no user-facing behavior change is intended unless a validation gap is found.

   ---

   Revision 1 — initial plan
3. zredlined

   added

   state:review-readyReady for human reviewReady for human review

   on May 21, 2026
4. RanPollak

   added a commit that references this issue on May 25, 2026

   fix(tests): Add hostname parser security regression tests (NVIDIA#1498)

   ...

   bd56398
5. johntmyers

   added

   gator:validatedGator validated this issue as ready for workGator validated this issue as ready for work

   on Jun 3, 2026
6. johntmyers commented on Jun 3, 2026

   

   johntmyers

   on Jun 3, 2026

   Collaborator

   More actions

   gator-agent

   Validated

   This issue is valid for OpenShell because it is a focused sandbox security/testing item with maintainer-authored scope and an active linked PR (#1562).

   Recommended next step: track the linked PR through review and CI.
7. github-actions commented on Jun 19, 2026

   

   github-actionsBot

   on Jun 19, 2026 – with GitHub Actions

   More actions

   This issue has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. Comment or remove the state:stale label to keep it open.
8. github-actions

   added

   state:staleInactive item at risk of automatic closure.Inactive item at risk of automatic closure.

   on Jun 19, 2026
9. johntmyers

   closed this as completedin #2197on Jul 9, 2026