Repository navigation
Conversation
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se> Signed-off-by: "Christina Tånnander" <christina.tannander@mtm.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
for more information, see https://pre-commit.ci
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
for more information, see https://pre-commit.ci
Signed-off-by: Jim O'Regan <joregan@kth.se>
…ssing into swedish-updates Signed-off-by: Jim O'Regan <joregan@kth.se>
jimregan
force-pushed
the
swedish-updates
branch
from
August 7, 2026 21:57
e4f7d5a to
bc1c02c
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Member
|
@jimregan Thanks for the contributions. Will be reviewing over next week, just sourcing language speakers to evaluate the test cases (you'll see additional reviewer beyond myself, they'll be going over the test cases). |
j-l-thorsson
left a comment
j-l-thorsson
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the Swedish test cases for language correctness, with TTS in mind. Left a few comments on written conventions and additional examples.
Signed-off-by: Jim O'Regan <joregan@kth.se>
Member
|
@jimregan doing technical review aspect, please let me know if any conflict with ongoing language changes. |
tbartley94
requested changes
Sep 25, 2026
tbartley94
left a comment
tbartley94
left a comment
Member
There was a problem hiding this comment.
Stylistic changes and implementation discussion. Need use of aliases instead of relying on f-string formatting in order to aid maintenance.
| optional_minus_graph = pynini.closure(pynutil.insert("negative: ") + pynini.cross("-", "\"true\" "), 0, 1) | ||
|
|
||
| final_graph = optional_minus_graph + pynutil.insert("integer: \"") + self.graph + pynutil.insert("\"") | ||
| reference_graph = pynini.Fst() |
Member
There was a problem hiding this comment.
rationale for building an empty fst? backend autocasts
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
…ssing into swedish-updates Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
jimregan
force-pushed
the
swedish-updates
branch
from
October 15, 2026 14:40
cb3071b to
d62b4b1
Compare
Signed-off-by: Jim O'Regan <joregan@kth.se>
for more information, see https://pre-commit.ci
Signed-off-by: Jim O'Regan <joregan@kth.se>
Signed-off-by: Jim O'Regan <joregan@kth.se>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
This incorporates additional items imported from Sardin, the open source version of the internal phonetisation system from MTM (Myndigheten för tillgängliga medier/Swedish Agency for Accessible Media)
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.