Repository navigation
Conversation
calculate_pareto_front dropped a row only when the current point was strictly better on every objective, so rows that tie on one objective and are worse on another stayed on the front, and with it in pareto_front(), get_best_result() and Search.best_result. Keep a row only when it is strictly better on some objective or equal on all of them; identical rows still all stay. Update the two assertions that encoded the old behavior. Closes NVIDIA#77 Signed-off-by: Dezhen Lu <dezhen.lu@student.uni-tuebingen.de>
0z5a
requested review from
nv-asrikanth,
nvptorru,
pnwamk and
vcruzer
as code owners
November 17, 2026 14:20
Collaborator
|
Thanks for the fix and the clear reproducer. Agreed that this is the preferred behavior. I'll run the CI. |
Collaborator
|
/ok to test b5d4a3f |
pnwamk
approved these changes
Nov 18, 2026
Collaborator
|
/ok to test 160652c |
pnwamk
enabled auto-merge (squash)
November 18, 2026 02:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SearchResult.calculate_pareto_frontdropped a row only when the current point was strictly better on every objective (np.any(scores <= point)kept everything else). Rows that tie the point on one objective and are worse on another stayed on the front. That also affectspareto_front(),get_best_result()(default for multi-objective) andSearch.best_result.This PR keeps a row when it is strictly better than the point on some objective, or equal to it on every objective. Identical rows still all stay on the front, as
test_identical_points_both_on_frontexpects. That is the definition written in the test class docstrings: A dominates B if A is no worse on every objective and strictly better on at least one.Two existing assertions encoded the old behavior and are updated:
(1,5)next to(1,1)is now excluded (it was asserted to stay "equal on dim 0").(5,1)next to(5,5)is now excluded (it was asserted to "trade off").Closes #77
Checklist
Validation
pytest tests/unit/test_results_pareto.py: onmain6 of 14 tests fail (the 2 updated assertions plus 4 new tests). With this change all 14 pass.main24/1000, this PR 1000/1000.calculate_pareto_frontis only called after the search finishes, so this is not a hot path. With 5,000 rows of (time, spills), the median of 5 runs goes from 50.49 ms to 2.45 ms, because fewer rows survive each pass.Bug fix
This change was drafted with Claude Code (claude-opus-5-5); the test results above are from the runs described.