[jekoorn]

I think in the end it boils down to regenerating the lockfile.
Edit: and the workflows.

Do we want to do something similar as in https://github.com/NNPDF/eko/pull/528/changes
with installing python in the bench, instead of loading an image?

[felixhekhorn]

Do we want to do something similar as in https://github.com/NNPDF/eko/pull/528/changes
with installing python in the bench, instead of loading an image?

in principle yes (to avoid complicated image generation), but as you can see we are getting in trouble with LHAPDF - however, maybe we can get around that thanks to NeoPDF? @Radonirinaunimi ? i.e. we would need to rewrite the benchmarks to use NeoPDF, which should be easy?

(Locally LHAPDF works for you, right?)

[Radonirinaunimi]

in principle yes (to avoid complicated image generation), but as you can see we are getting in trouble with LHAPDF - however, maybe we can get around that thanks to NeoPDF? @Radonirinaunimi ? i.e. we would need to rewrite the benchmarks to use NeoPDF, which should be easy?

Yes 😃 I'd actually advocate to replace all the containers and custom-build of LHAPDF in the CI with NeoPDF 🙈

Making those changes should be as easy as:

from neopdf.pdf import PDF as lhapdf

and the rest should be exactly the same.

[jekoorn]

(Locally LHAPDF works for you, right?)

Locally LHAPDF is giving me issues, too. Unsure yet what exactly is going wrong. It also has trouble finding the pineko.toml (I added it)
Let's see what happens when I use neoPDF

[jekoorn]

Is this code supposed to fail all benchmarks? How come this is suddenly an issue? Because we are moving away from containers? There are many missing files in the benchmarks folder of which I have no idea what they are supposed to be - how to proceed here? In the end the issue doesn't look like it's LHAPDF but just in general the benchmarks.
pylint src/ -E passes with no issue.

[felixhekhorn]

Is this code supposed to fail all benchmarks?

no, but before we see the error message I can't tell you what the problem is ... does it work locally?

How come this is suddenly an issue? Because we are moving away from containers? There are many missing files in the benchmarks folder of which I have no idea what they are supposed to be - how to proceed here? In the end the issue doesn't look like it's LHAPDF but just in general the benchmarks. pylint src/ -E passes with no issue.

well, this is just a clear signal that pineko is essentially unmaintained - as we keep telling the collaboration since more than a year by now ... consider volunteering yourself ... and if you say "no thanks I already have been volunteered for yadism" we should ask at the PC again if someone does FK tables and I wonder what the reply will be ... 🤯 🔥

[felixhekhorn]

to clarify: I sent the above comment about 2 second before we had the results - and now we know, the two problems:

FAILED benchmarks/bench_evolve.py::benchmark_evolve_grid - AttributeError: type object 'builtins.PDF' has no attribute 'paths'
FAILED benchmarks/bench_kfactor.py::benchmark_kfactor_inclusion - AttributeError: type object 'builtins.PDF' has no attribute 'mkAlphaS'

so the answer is: neopdf is not a simple drop-in replacement, but we need to adjust out code with the two respective things; maybe @Radonirinaunimi can help?