Skip to content

chore(evidence): remove the plan-format checks, their validator and sample plans - #18

Merged
MrScripty merged 4 commits into
mainfrom
chore/remove-plan-format-checks
Nov 14, 2026
Merged

MrScripty merged 4 commits into
mainfrom
chore/remove-plan-format-checks

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

Summary

Removes the plan-format checks. The owner has decided that the plan template is a guide and that the layout of a plan is not something to verify.

The 19 plan_contract checks in suite planning-consolidation ran a layout validator on 19 sample plans and nothing else. No check ran it on a real plan, and run by hand it rejects 25 of the 28 plans under docs/plans/. The checks worked as written, but what they checked is not a requirement, so they are removed and not repaired.

Three commits:

  1. Retire the checks through the Engine's maintain_evidence operation. This removes the suite, its 19 checks, its registry entry, its catalogue node and the four relationships that named the suite as consumer and evidence owner. Each of the four policy units keeps its other consumers.
  2. Remove the validator: the plan_contract check kind, its registration, its unit test (3 tests) and its README row. A suite that still declares the kind now fails with CONFIG.UNKNOWN_CHECK.
  3. Retire the 19 sample plans through maintain_evidence. They go last because the validator's unit test read them.

templates/PLAN-TEMPLATE.md is kept. The record is docs/audits/plan-format-check-removal-2026-11-13.md.

What follows

Two sentences still say plan structure is verified by fixtures. They are standards text, so they are corrected through the authoring workflow in the next pull request, which can be accepted or rejected on its own.

Verification

On the last commit of this stack: twelve package suites (700 tests; the verifier suite has 193, three fewer than before), the Engine suite (688 tests) and verify.py --complete (22 of 22 suites) pass, and the working tree is clean. Each commit passes verify.py --complete on its own. Counts: suites 23 to 22, checks 66 to 47.

Stack

Second of three; contains the commit from the first. Review the last three commits. Merge with a merge commit: later records cite commit hashes, so squashing or rebasing would invalidate them.

🤖 Generated with Claude Code

MrScripty and others added 4 commits November 13, 2026 18:39
release-maintenance-policy/metadata-closure validated a hand-typed list of
12 module paths. The whole-corpus check canonical-corpus-metadata/
canonical-corpus already validates all 74 canonical modules through the same
call, so the listed check could not fail for a reason the corpus check does
not also report. A mutation test confirmed it: 48 metadata defects across the
12 listed modules failed both checks with the same diagnostic each time.

The retirement was made by the Engine's maintain_evidence operation (preview,
then apply), not by hand. Retiring the only check emptied the suite, so the
Engine also removed the suite, its registry entry and its enforcement-suite
node in the policy-impact catalogue. No relationship named the node or the
suite, so none changed.

Fifty-five sibling checks were retired earlier; this one was held back because
the node catalogue digest is part of every coverage requirement. Removing the
node changes all 53 requirement IDs and turns the 16 current certificates
stale. The owner has accepted that; the certificates are left in place and
reissued in a later commit, each after review.

docs/audits/metadata-closure-retirement-2026-11-13.md is the review record
supplied to the operation.

Suites 24 -> 23, checks 67 -> 66, catalogue nodes 122 -> 121, certificates
current/stale 16/8 -> 0/24.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The owner has decided that the plan template is a guide and that the layout
of a plan is not something to verify. The 19 plan_contract checks in suite
planning-consolidation ran a layout validator on 19 sample plans and nothing
else: no check ran it on a real plan, and run by hand it rejects 25 of the 28
plans under docs/plans. The checks worked as written, but what they checked is
not a requirement, so they are removed rather than repaired.

The removal was made by the Engine's maintain_evidence operation (preview,
then apply), not by hand. Retiring the suite removed its 19 checks, its
registry entry, its enforcement-suite node in the policy-impact catalogue and
the four relationships that named the suite as consumer and evidence owner
(from workflow.planning.active-plan-fields, workflow.planning.lifecycle-
authority, topic.architecture.composed-design-admission and
workflow.commit.per-commit-boundary). No other relationship named the suite,
so no evidence owner was replaced. Each of the four units keeps its template,
prompt, documentation and normative consumers.

The validator code and the sample plans follow in the next two commits; the
samples go last because the validator's unit test reads them.
templates/PLAN-TEMPLATE.md is kept.

Every certificate is already stale after the metadata-check retirement. Two
of them cite the retired suite file as evidence; a stale certificate is
ignored on load, so they stay in place until they are reissued.

docs/audits/plan-format-check-removal-2026-11-13.md is the review record
supplied to the operation.

Suites 23 -> 22, checks 66 -> 47, catalogue nodes 121 -> 120, policy-impact
relationships 356 -> 352.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The plan_contract check kind validated the layout of a plan document. Its
only suite, planning-consolidation, was retired in the previous commit after
the owner decided the plan template is a guide rather than something to
verify, so the validator has no caller left.

Remove the check implementation, its registration in the check parser, its
unit test (3 tests) and its row in the README's check-kind table. A suite that
still declares a plan_contract check now fails with CONFIG.UNKNOWN_CHECK,
like any other unsupported kind.

Nothing else used the validator. The sample plans its unit test read are
retired through the Engine in the next commit. templates/PLAN-TEMPLATE.md is
unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The 19 files under evaluation/standards-effectiveness/fixtures/plans/ were
the inputs of the plan_contract checks and of the validator's unit test. Both
are gone, so nothing reads the samples any more.

The files were removed by the Engine's maintain_evidence operation (preview,
then apply) with retire_inputs, not by hand. The operation refuses an input a
retained suite still uses; none did. No suite, catalogue node, relationship
or certificate changes.

This is a separate commit from the suite retirement so that the validator's
unit test never ran without the samples it read.

docs/audits/plan-format-check-removal-2026-11-13.md is the review record
supplied to the operation.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 18587f50-92a5-40a8-b9af-e29fd4500b36
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@MrScripty
MrScripty merged commit 0c9b17a into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant