Skip to content

chore(evidence): retire the last hand-listed metadata check - #17

Merged
MrScripty merged 1 commit into
mainfrom
chore/retire-metadata-closure-check
Nov 14, 2026
Merged

MrScripty merged 1 commit into
mainfrom
chore/retire-metadata-closure-check

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

Summary

Retires release-maintenance-policy/metadata-closure, the last check that validated a hand-typed list of module paths. The whole-corpus check added in #13 (canonical-corpus-metadata/canonical-corpus) validates all 74 modules through the same call, so this check could not fail for a reason the corpus check does not also report.

  • The retirement was made by the Engine's maintain_evidence operation (preview, then apply), not by hand.
  • Retiring the only check emptied the suite, so the Engine also removed the suite, its registry entry and its node in the policy-impact catalogue. No relationship named the node.
  • A mutation test backs the claim: 48 metadata defects across the 12 listed modules failed both checks with the same diagnostic each time. The record is docs/audits/metadata-closure-retirement-2026-11-13.md.

Effect on coverage certificates

The catalogue digest is part of every coverage requirement, so removing the node makes the 16 current certificates stale (24 of 24 stale after this change). That was the reason this check was held back in #13, and the owner has accepted it. A stale certificate blocks nothing: the verifier, the tests and the Engine's propose and apply steps all pass. The certificates are reissued after review in later work.

Verification

On the last commit of this stack: twelve package suites (700 tests), the Engine suite (688 tests) and verify.py --complete (22 of 22 suites) pass, and the working tree is clean. After this commit alone, verify.py --complete passes 23 of 23.

Stack

First of three. Merge with a merge commit: later records cite commit hashes, so squashing or rebasing would invalidate them.

🤖 Generated with Claude Code

release-maintenance-policy/metadata-closure validated a hand-typed list of
12 module paths. The whole-corpus check canonical-corpus-metadata/
canonical-corpus already validates all 74 canonical modules through the same
call, so the listed check could not fail for a reason the corpus check does
not also report. A mutation test confirmed it: 48 metadata defects across the
12 listed modules failed both checks with the same diagnostic each time.

The retirement was made by the Engine's maintain_evidence operation (preview,
then apply), not by hand. Retiring the only check emptied the suite, so the
Engine also removed the suite, its registry entry and its enforcement-suite
node in the policy-impact catalogue. No relationship named the node or the
suite, so none changed.

Fifty-five sibling checks were retired earlier; this one was held back because
the node catalogue digest is part of every coverage requirement. Removing the
node changes all 53 requirement IDs and turns the 16 current certificates
stale. The owner has accepted that; the certificates are left in place and
reissued in a later commit, each after review.

docs/audits/metadata-closure-retirement-2026-11-13.md is the review record
supplied to the operation.

Suites 24 -> 23, checks 67 -> 66, catalogue nodes 122 -> 121, certificates
current/stale 16/8 -> 0/24.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41e471a0-9716-4149-8d0d-e21d5281fcf0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@MrScripty
MrScripty merged commit 054bdc7 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant