Repository navigation
NodeNotes 0.4.0: chests, rares, special finds, sharing - #1
Merged
Merged
Conversation
- Rares: sightings from target, mouseover and nameplates, kills with their drop on loot. Skull pins that follow the rare. - Special finds: blue or better mob drops get their own pin (/nn finds on|off|green|blue|epic). - Chests on by default, named from the Opening cast, quest-only objects skipped. Upgrading from 0.3.0 renames "other" nodes to chests and turns chests on once. - Coloured ring for nodes that gave a blue or better. - Continent map pins, square minimap support. - Gather casts recognised by spell id and localized spell name. - Optional sharing with group or guild (/nn share, /nn friends), off by default, with validated and cleaned incoming messages. - Harness covers every new path. README, changelog and two GIFs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeNotes 0.4.0.
/nn finds on|off|green|blue|epic).othernodes to chests and turns chests on once./nn continent on|off) and square minimap support./nn share group|guild|both|off|sync,/nn friends on|off|clear). Off by default, sent at about one message a second, never in combat. Incoming messages are validated and stripped of escape codes.docs/demo.gif) and an animated screenshot (docs/map-note.gif), plus the scripts that build them.Share.lua is a new TOC file, so the game needs a full restart after updating, not just
/reload. Core works without it if someone only reloads.Tested with the harness under LuaJIT. The new sections cover chests, quest-only objects, finds, rares, continent pins, the square minimap, sharing encode/decode/send/receive and the 0.3.0 migration. Not yet tested in game.