Skip to content

Add the check-citation-authors caller - #643

Open
d-morrison wants to merge 1 commit into
mainfrom
claude/check-citation-authors-caller
Open

d-morrison wants to merge 1 commit into
mainfrom
claude/check-citation-authors-caller

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Adds a caller for gha's new check-citation-authors check (Morrison-Lab/gha#2149, wiring issue Morrison-Lab/gha#2150), now at @v3.

It flags a line a PR adds that types an author's surname next to a citation of the same source, such as James et al. [@james2021islr, Figure 6.7], where @james2021islr [Figure 6.7] already prints the names (psw#679, "Let the citation name the source").
The check is diff-scoped and warn-only (fail: false). Where annotation-gate runs, its warning fails the run, as with check-avoided-words.
A manual run scans the whole tree.

paths-ignore copies this repo's check-avoided-words caller.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VDkNzpX17QNruwBjGgDqfM
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Inputs all exist and match. Minor: no paths-ignore **/outtakes/** concern.

Review of PR #643 — add check-citation-authors caller workflow

The PR adds one file, .github/workflows/check-citation-authors.yml. It is a thin caller of the reusable workflow in Morrison-Lab/gha.

I checked it against .reference-repos/Morrison-Lab/gha/.github/workflows/check-citation-authors.yml:

  • Inputs: fail, whole-tree and paths-ignore are all declared workflow_call inputs, with matching types (boolean, boolean, string).
  • Reusable workflow path: @v3 matches how the other callers in this repo reference gha.
  • Permissions: contents: read matches the called workflow's own permission block.
  • Triggers: pull_request and workflow_dispatch follow the repo's other warn-only checks (for example check-term-links.yml). The header comment explains why there is no push trigger.
  • Whole-tree runs: whole-tree is true only on a manual run, which fits the comment "A manual run scans the whole tree."
  • Ignore globs: the ** patterns follow the convention noted in check-term-links.yml. The ignored paths (_extensions/, outtakes/, latex-macros/) are plausible for this repo.
  • Fail mode: fail: false matches the gha default, which is warn-only while the false-positive rate is measured.

The PR changes no prose, math or R code, so the content rules and the macro check do not apply. I cannot confirm that gha#2149 and gha#2150, cited in the header comment, exist as described, but this does not affect correctness.

I found no blocking issues.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "16e123ead98ff1b068152ff4705f29d10109cb2c",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new check-citation-authors.yml caller passes only inputs (fail, whole-tree, paths-ignore) that the reusable gha workflow declares, with matching types, and its permissions match.",
  "holistic_assessment": "A single warn-only workflow file consistent with the repo's other gha callers, with no content, math, or R changes, so regression and scope risk are minimal."
}

Reviewed commit: 16e123e

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1988 (review) — run

Copy link
Copy Markdown
Contributor Author

The link-checker / link-checker failure here isn't caused by this PR. Every error is Connection failed to web.stanford.edu, and the same links passed on main's most recent link-checker run. The diff adds one workflow file and changes no links. A re-run at 01:00 PT failed the same way, so the host still isn't answering. The annotation-gate failure is that same error passed along.

This PR stays open until web.stanford.edu answers again and the link check passes.


Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/sds/pr-preview/pr-643/

Built to branch gh-pages at 2026-11-20 09:04 UTC.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants