You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It flags a line a PR adds that types an author's surname next to a citation of the same source, such as James et al. [@james2021islr, Figure 6.7], where @james2021islr [Figure 6.7] already prints the names (psw#679, "Let the citation name the source").
The check is diff-scoped and warn-only (fail: false). Where annotation-gate runs, its warning fails the run, as with check-avoided-words.
A manual run scans the whole tree.
paths-ignore copies this repo's check-avoided-words caller.
Inputs all exist and match. Minor: no paths-ignore**/outtakes/** concern.
Review of PR #643 — add check-citation-authors caller workflow
The PR adds one file, .github/workflows/check-citation-authors.yml. It is a thin caller of the reusable workflow in Morrison-Lab/gha.
I checked it against .reference-repos/Morrison-Lab/gha/.github/workflows/check-citation-authors.yml:
Inputs:fail, whole-tree and paths-ignore are all declared workflow_call inputs, with matching types (boolean, boolean, string).
Reusable workflow path:@v3 matches how the other callers in this repo reference gha.
Permissions:contents: read matches the called workflow's own permission block.
Triggers:pull_request and workflow_dispatch follow the repo's other warn-only checks (for example check-term-links.yml). The header comment explains why there is no push trigger.
Whole-tree runs:whole-tree is true only on a manual run, which fits the comment "A manual run scans the whole tree."
Ignore globs: the ** patterns follow the convention noted in check-term-links.yml. The ignored paths (_extensions/, outtakes/, latex-macros/) are plausible for this repo.
Fail mode:fail: false matches the gha default, which is warn-only while the false-positive rate is measured.
The PR changes no prose, math or R code, so the content rules and the macro check do not apply. I cannot confirm that gha#2149 and gha#2150, cited in the header comment, exist as described, but this does not affect correctness.
I found no blocking issues.
Verdict
Ready for merge
Structured Review Data (JSON)
{
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "16e123ead98ff1b068152ff4705f29d10109cb2c",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new check-citation-authors.yml caller passes only inputs (fail, whole-tree, paths-ignore) that the reusable gha workflow declares, with matching types, and its permissions match.",
"holistic_assessment": "A single warn-only workflow file consistent with the repo's other gha callers, with no content, math, or R changes, so regression and scope risk are minimal."
}
The link-checker / link-checker failure here isn't caused by this PR. Every error is Connection failed to web.stanford.edu, and the same links passed on main's most recent link-checker run. The diff adds one workflow file and changes no links. A re-run at 01:00 PT failed the same way, so the host still isn't answering. The annotation-gate failure is that same error passed along.
This PR stays open until web.stanford.edu answers again and the link check passes.
Posted by Claude Code (AI agent) --- not written by a human.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a caller for gha's new
check-citation-authorscheck (Morrison-Lab/gha#2149, wiring issue Morrison-Lab/gha#2150), now at@v3.It flags a line a PR adds that types an author's surname next to a citation of the same source, such as
James et al. [@james2021islr, Figure 6.7], where@james2021islr [Figure 6.7]already prints the names (psw#679, "Let the citation name the source").The check is diff-scoped and warn-only (
fail: false). Where annotation-gate runs, its warning fails the run, as withcheck-avoided-words.A manual run scans the whole tree.
paths-ignorecopies this repo'scheck-avoided-wordscaller.Generated by Claude Code