Skip to content

chore: sync vendored fragments from Morrison-Lab/qwt - #184

Open
d-morrison wants to merge 1 commit into
mainfrom
automated/sync-site-scaffolding
Open

d-morrison wants to merge 1 commit into
mainfrom
automated/sync-site-scaffolding

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Automated refresh of vendored fragments from
Morrison-Lab/qwt.
Each file is pinned to the last upstream commit that touched it; see
the manifest for the exact commits.

Don't hand-edit the vendored files -- edit them upstream and let this
workflow refresh the copy. Generated by the sync-shared-fragments
reusable workflow in Morrison-Lab/gha.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Low-risk change. The three vendored files match the SHA-256 values recorded in .github/site-scaffolding.json, so they are faithful copies of the pinned qwt commits. I did not diff them against the upstream commits.

Findings

Suggestion (non-blocking): CLAUDE.md:23 is now stale.

  • It still says the theme choice is saved under mln-theme.
  • After this PR the key is lds-theme, with mln-theme read only as a fallback.
  • Update that line to say so. It is a doc-accuracy point only.

Noted: no migration of the old key.

  • theme-picker.html and qwt-reveal-toggle.html read lds-theme first, then mln-theme. A returning visitor keeps their saved theme.
  • I did not check whether the scripts write the choice back to mln-theme too. If they write only lds-theme, a mln-theme value on the same origin will go stale. That is fine if nothing else reads it.

Noted: offwhite.scss sidebar background.

  • The new rule sets $page as the background for the docked sidebar, its mobile rollup and the secondary nav. That is plausible for the stated bug (a white sidebar on a tinted page).
  • I did not render it, so the dark and parchment palettes are unchecked.

No bugs, broken links or build-hygiene problems in the diff. There is no math or prose to check against the macros or the line-break rules.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "9ce7d5509563cb27e337b265370800732f2b3bca",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Vendored theme-picker.html, qwt-reveal-toggle.html and offwhite.scss match the sha256 values recorded in site-scaffolding.json; the localStorage key fallback logic is correct. Only CLAUDE.md line 23 still names the old mln-theme key.",
  "holistic_assessment": "Scope is a pure scaffolding sync from qwt with no new dependencies, build artifacts or CI changes; the stale CLAUDE.md description of the storage key is a non-blocking documentation follow-up."
}

Reviewed commit: 9ce7d55

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1814 (review) — run

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/psc/pr-preview/pr-184/

Built to branch gh-pages at 2026-11-16 16:45 UTC.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant