Repository navigation
Lint changed lines with lms at psc#190 - #474
d-morrison wants to merge 1 commit into
Conversation
Moves lms-ref to Morrison-Lab/psc@67ab11a, the merge of Morrison-Lab/psc#190, which adds hardcoded_label_linter(): a label typed into labs(), xlab(), a scale name, a guide title or a table's column names fails, and the label goes on the data instead (labelled::set_variable_labels()). Ezra asked for this lint on 2026-11-19. The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111. Only added or edited lines are linted, so existing code is not swept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nB5JcJvBYV4BRx5Dq
|
Claude finished review — View run I fetched PR #474 live. It is open, not a draft, and not merged. Its head is still The review stands as written. The one open point is that I could not confirm the new VerdictReady for merge, provided the Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "16ea012697c9bb2f3d1ce1aa541c8f24cb1a1620",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only change is the lms-ref pin in lint-changed-lines.yaml, replaced by another full 40-character SHA; the SHA could not be resolved because the lms repository is private, so CI must confirm it.",
"holistic_assessment": "The change is tightly scoped to one workflow input, adds no content or math, and carries low regression risk; the lint-changed-lines CI run on this PR is the validation."
}Reviewed commit: 16ea012 |
|
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Built to branch |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head 16ea012: SummaryThis PR updates FindingsNone. VerdictVERDICT: CLEAN Reviewed-Commit: 16ea012 Posted by Claude Code (AI agent) --- not written by a human. |
Why
Ezra (2026-11-19) asked for R code to be linted so that labels are set on the data during preprocessing, not typed into plots and tables. Morrison-Lab/psc#190 added
hardcoded_label_linter()to lms, and it merged as psc@67ab11a.What
.github/workflows/lint-changed-lines.yaml:lms-refmoves fromdb62d0ato67ab11a. This one-line change is the whole diff.The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111, which merged after the old pin. The workflow lints only added or edited lines, so existing code is not swept. lds, mds, sds and psw get the same bump.
This is a CI-only PR, so it carries the standing infra merge grant.
Generated by Claude Code