Skip to content

Lint changed lines with lms at psc#190 - #474

Open
d-morrison wants to merge 1 commit into
mainfrom
claude/lms-ref-labels
Open

d-morrison wants to merge 1 commit into
mainfrom
claude/lms-ref-labels

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Why

Ezra (2026-11-19) asked for R code to be linted so that labels are set on the data during preprocessing, not typed into plots and tables. Morrison-Lab/psc#190 added hardcoded_label_linter() to lms, and it merged as psc@67ab11a.

What

  • .github/workflows/lint-changed-lines.yaml: lms-ref moves from db62d0a to 67ab11a. This one-line change is the whole diff.

The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111, which merged after the old pin. The workflow lints only added or edited lines, so existing code is not swept. lds, mds, sds and psw get the same bump.

This is a CI-only PR, so it carries the standing infra merge grant.


Generated by Claude Code

Moves lms-ref to Morrison-Lab/psc@67ab11a, the merge of
Morrison-Lab/psc#190, which adds hardcoded_label_linter(): a label
typed into labs(), xlab(), a scale name, a guide title or a table's
column names fails, and the label goes on the data instead
(labelled::set_variable_labels()). Ezra asked for this lint on
2026-11-19. The new pin also brings the dplyr-subsetting linter from
Morrison-Lab/psc#111. Only added or edited lines are linted, so
existing code is not swept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9nB5JcJvBYV4BRx5Dq
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #474 live. It is open, not a draft, and not merged. Its head is still 16ea012697c9bb2f3d1ce1aa541c8f24cb1a1620, the commit I reviewed.

The review stands as written. The one open point is that I could not confirm the new lms-ref SHA exists, because Morrison-Lab/lms looks private to me. The lint-changed-lines check on this PR will show whether the SHA resolves.

Verdict

Ready for merge, provided the lint-changed-lines check passes.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "16ea012697c9bb2f3d1ce1aa541c8f24cb1a1620",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only change is the lms-ref pin in lint-changed-lines.yaml, replaced by another full 40-character SHA; the SHA could not be resolved because the lms repository is private, so CI must confirm it.",
  "holistic_assessment": "The change is tightly scoped to one workflow input, adds no content or math, and carries low regression risk; the lint-changed-lines CI run on this PR is the validation."
}

Reviewed commit: 16ea012

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2081 (review) — run

Copy link
Copy Markdown
Contributor Author

link-checker fails, but not because of this PR. Every blocking error is a connection failure to web.stanford.edu: 8 links on pages this PR does not touch, including cs109, stats116, ee278 and stats311. This PR changes only .github/workflows/lint-changed-lines.yaml. It failed the same way on the first run and on its one re-run (attempt 2 of run 44700442859), and mds and sds hit the same host at the same time. So the whole host is unreachable from the runners; nothing in this diff is broken. The check should clear once Stanford's site is reachable again.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/pds/pr-preview/pr-474/

Built to branch gh-pages at 2026-11-20 08:26 UTC.

@d-morrison

Copy link
Copy Markdown
Contributor Author

Cross-model review (agy, gemini-4-hydrogen-high) of head 16ea012:

Summary

This PR updates .github/workflows/lint-changed-lines.yaml in Morrison-Lab/pds by changing the lms-ref input from db62d0af4b618da4691ffa5d97d2656c4b286dd9 to 67ab11a4dcfbd93684353d0a2e10c26a9d41e77f. Based solely on the provided PR text and diff, the file path, full 40-character SHA, short prefixes (db62d0a and 67ab11a), commit URL, and one-line diff scope all match between the description and the diff, and YAML indentation is preserved.

Findings

None.

Verdict

VERDICT: CLEAN

Reviewed-Commit: 16ea012

Posted by Claude Code (AI agent) --- not written by a human.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants