Repository navigation
Add \ball for the open ball around a center - #438
Conversation
mds defines the open ball (vector-calculus.qmd#def-ball) but gives it
no symbol, so its local maximizer and minimizer definitions restate
the ball's inequality (||x - x*|| < delta) instead of naming the set.
\ball{center}{radius} prints B_r(x), so those conditions can read
"x in B_delta(x*)". \ballsym prints the symbol alone.
Adds the interpretations.tsv rows, the regenerated symbols file, a
notation-choices.qmd entry, and a PDF test that an exponent rises over
a tall center and the radius prints as a subscript, with an unbraced
control that must not rise.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9oqRg66ANhcYmtpmq3
|
/review Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The review found the depth test cannot pass: the parenthesis already reaches 2.5pt below the baseline, as deep as the subscript, so the depth difference is zero. The radius subscript does add width, so compare widths, and check that a body without the radius reports missing. Also say how a ball differs from the coefficient B (\Regcoef), and put one clause per line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9oqRg66ANhcYmtpmq3
|
/review Changes in
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Cross-model review (agy, gemini-4-hydrogen-high) of head ac93b7f: SummaryPR Findings
VerdictVERDICT: NOT CLEAN Reviewed-Commit: ac93b7f Posted by Claude Code (AI agent) --- not written by a human. |
\ball prints B_r(x), so listing it under "other sources write" presented our convention as an outside alternative (agy review on macros#438). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9oqRg66ANhcYmtpmq3
|
/review I addressed the agy finding in Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Claude finished review — View run I reviewed the one commit added since the last round, The edit is correct and needs no further change.
My earlier verdict still stands: the 2026-11-20 review of VerdictReady for merge, assuming the Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b2be0adbf612f270926012626ef8b05aa93fd702",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only change since the last round is one line in notation-choices.qmd that removes B_r(x) from the other-sources list, which is accurate and grammatical.",
"holistic_assessment": "The prior CLEAN verdict on ac93b7f still stands; this docs-only edit touches no macro, test or CSV, and the remaining risk is the CI check-latex job being the first compile of the width test."
}Reviewed commit: b2be0ad |
Built to branch |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head b2be0ad: SummaryPR The earlier agy review's finding is resolved: FindingsNone. VerdictVERDICT: CLEAN Reviewed-Commit: b2be0ad Posted by Claude Code (AI agent) --- not written by a human. |
|
Annotation dispositions for head b2be0ad: Check runs 136207817435,136207813265,136207812911:
Posted by Claude Code (AI agent) --- not written by a human. |
Requested by Ezra · project thread
Why
Ezra asked that the mds local maximizer definition write its condition $\norm{x - x^} < \delta$ as "x is in the δ-radius ball around x".
mds already defines the open ball, but that definition gives it no symbol, and these macros had no ball macro.
What
\ball{center}{radius}prints\ballsymprints the symbolinterpretations.tsvrows for both, and a regenerateddata/symbols-all.csv.notation-choices.qmdentry, "The open ball".It covers our convention, why we use it for neighborhood conditions, and how a ball differs from the coefficient
\Regcoef).It also lists the alternatives
_tests/ball-exponent.qmdand its markers intools/check_latex.py.The test checks that an exponent after
\ball{\frac{a}{b}}{r}rises, and that the radius subscript prints, measured as added width.Each check has a control that must fail: an unbraced body must not rise, and a body without the radius must come out missing.
Checks run locally
python3 tools/gen_symbols.py --check: passes.tools/check_symbols_mathjax.py: 1219 symbols typeset, 0 failures.python3 tools/check_latex.pywith TinyTeX: exit 0.ball-exponent.pdfprintsBALLEXPRISES,BALLRADIUSPRINTED,RADIUSCTRLMISSINGandCTRLSTUCK.cut -f1 interpretations.tsv | sort | uniq -d: no duplicate keys.Follow-up
Morrison-Lab/mds#866 uses the macro.
It is pinned to this branch, and it will be re-pinned to the merge commit.
🤖 Generated with Claude Code
https://claude.ai/code/session_019xfc9oqRg66ANhcYmtpmq3