Repository navigation
annotation-gate: name the runs a deferred gate waits on - #2152
d-morrison wants to merge 6 commits into
Conversation
A gate deferred by defer-while-running printed only a count, so a gate held behind a full self-hosted pool looked like one that never posted. It now emits a notice and a step-summary list with each waiting run's name, status, age in minutes and link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nLowW5puRpJrWhahm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotation dispositions for head d6004d3: None of the annotations on this head needs a fix in this PR. I read all 109 runs with
Everything else matches main, including the selftest negative controls ( Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
A run name holding %, CR or LF would end the ::notice command early or start a new one. Escape the data part as GitHub's toolkit does. Found by a cross-harness review (iceman-contributor-free) of gha#2152. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nLowW5puRpJrWhahm
|
Cross-harness review of head d6004d3: OpenCode
Fixed in baa2847. The notice data is now escaped as GitHub's toolkit does it ( Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotation dispositions for head baa2847: All checks on this head passed. I read the warning and failure annotations with
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-harness review of head baa2847 by opencode (
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head baa2847: SummaryThis PR adds Findings
VerdictThe implementation and tests are functionally solid, but the PR description and VERDICT: NOT CLEAN Reviewed-Commit: baa2847 Posted by Claude Code (AI agent) --- not written by a human. |
The log line still gives only a count; the notice and the job summary name the runs. The first deferral test now asserts the notice names the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nLowW5puRpJrWhahm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotation dispositions for head 75c315a:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
A run name or URL holding a line break was escaped for the ::notice command but written raw into GITHUB_STEP_SUMMARY, so it could split a list item or start new Markdown there. waiting_lines now collapses whitespace in the name and link, which covers the summary and the notice alike; command_data still escapes % and gets its own test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nLowW5puRpJrWhahm
|
Review replies, through head 6cbb91d:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotation dispositions for head 6cbb91d:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head 6cbb91d: SummaryRound 2 review of Both findings from the earlier review are resolved:
The implementation ( FindingsNone. VerdictAll round 1 findings are resolved and no new defects were found in the diff or PR description. VERDICT: CLEAN Reviewed-Commit: 6cbb91d Posted by Claude Code (AI agent) --- not written by a human. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotation dispositions for head a035b3e:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head a035b3e: SummaryPR The implementation, tests, docstrings, changelog entry, and PR description are consistent and free of defects. FindingsNone. VerdictVERDICT: CLEAN Reviewed-Commit: a035b3e Posted by Claude Code (AI agent) --- not written by a human. |
|
Claude finished review — View run PR #2152 has no new findings at The only change since the last review is The PR's own diff against its base is three files:
The prior round on The PR adds no math or notes content, so the macro and content rules do not apply. It changes no permissions or interfaces. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "a9b7fbf905d56675243f96a6141a08f7ea048f6c",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Re-read the full PR diff: report_deferral, waiting_lines, one_line and command_data in annotation_gate.py are unchanged since the last clean round, and the new merge commit matches git's automatic merge.",
"holistic_assessment": "The only new commit is a clean merge of main that brings in an unrelated check already on main, so scope, regression and interface risk are unchanged and the earlier clean verdict stands."
}Reviewed commit: a9b7fbf Reviewed commit: a9b7fbf |
Closes #2151.
With
defer-while-running, the annotation gate posts nothing while any other run on the head is still queued or in progress.When the self-hosted pool is full, that wait can last hours.
Until now the log said only how many runs were unfinished, so a gate that was held back looked like one that had never posted.
That is what happened on Morrison-Lab/lds on 2026-11-20: the gates were held, not lost.
Changes
annotation-gate/annotation_gate.pywaiting_lines()builds one line per unfinished run, giving its name, status, minutes since creation, and link.A new helper,
one_line(), collapses whitespace in the name and link, so a line break in a run name cannot split a job-summary list item or start new Markdown.command_data()escapes%, carriage returns and newlines, in that order, so a run name cannot break or inject a workflow command.report_deferral()replaces the bare count.The log line still gives only the count.
The runs are named in a
::notice title=Annotation gate deferred::and in a list appended to$GITHUB_STEP_SUMMARYwhen that file is set.annotation-gate/tests/test_annotation_gate.pyhas five new tests:%in a run name, and a newline in the name does not start a new command;command_data()escapes%, CR and LF;changelog.d/annotation-gate-deferral-summary.changed.md: a changelog fragment.All 78 annotation-gate tests pass locally (
python3 -m pytest annotation-gate/tests -qprints78 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_019xfc9nLowW5puRpJrWhahm