Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Videos currently pause when Android moves the app into the background. This change adds optional screen-off audio playback and Android media controls, while keeping the existing player and playback position.
Changes
Validation
flutter test --no-pub: all 14 tests passed, including persistence, disabled-background resume, and replacement-player ownership.flutter analyze --no-pubon the changed code and tests: no issues.git diff --checkpassed.Device screenshots
Captured on the connected Android phone using the production player and settings menu in the smoke harness, with a fresh test profile and Big Buck Bunny sample media. The temporary screenshot installation was removed after testing.
Compatibility
Keep the Flutter compatibility flags for the legacy Android DSL and Kotlin plugin while dependencies still require them.
package_info_plusandxmlremain on their newest resolvable versions. Network live streams, incoming calls, release builds, and non-Android platform builds have not been device/build validated.