Repository navigation
docs(process): record a human's not-yet at completion review as a return to implementation - #59
Merged
Merged
Conversation
…urn to implementation The Epic and its owned requirements go back from IN_REVIEW to IN_PROGRESS with the plan, the implementation approval and the ownership kept. Both lifecycle lines show the transition; the IN_REVIEW paragraph says what is kept and what follows; rdd-completion-review step 5 records the answer with the unchanged retained presentation, reads the state back and continues the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
When the human answers "not yet" at completion review, the process now says what happens: the Epic and its owned requirements go back from
IN_REVIEWtoIN_PROGRESS. The plan, the implementation approval and the requirement ownership stay. The agent records the answer with the same completion presentation the human saw, reads the state back, continues the build, and submits for review again once whatever changed has been renewed.PROCESS.md: both lifecycle lines in the canonical model showIN_REVIEW -> IN_PROGRESS, and theIN_REVIEWparagraph says what is kept and what follows.skills/rdd-completion-review/SKILL.md: step 5 records the not-yet as a return to implementation. Like the other skills, it names no CLI command.Why
The ModernPath CLI and server gained this return (
epics plan return-to-implementation, ModernPath/modernpath-v1#970). Until the process names it, an agent at completion review only knows how to apply an approval.Relation to other open changes
#58 (return to planning) edits other paragraphs of
PROCESS.mdand other skills; this change touches neither. The two transitions differ: #58 returns an active Epic toPROPOSEDand ends its approval; this one keeps the approval and resumes implementation.Checks
git diff --checkis clean.scripts/sync-rdd-assets.sh(modernpath-v1#970), the new test of the return and the existing kit tests pass. The only other failure was the installed-copy drift check, whichmodernpath installclears after the re-pin.Merging is a human decision. After it merges, modernpath-v1#970 re-pins this revision only if the diff from its current pin (
9a1896b) holds nothing but this change.🤖 Generated with Claude Code