Repository navigation
docs(rdd-audit): name the CLI's citation audit and retire audit-citations.mjs - #39
Open
jussi-modernpath wants to merge 2 commits into
Open
jussi-modernpath wants to merge 2 commits into
jussi-modernpath wants to merge 2 commits into
Conversation
…ions.mjs The citation audit that rdd-audit prescribes, and that rdd-cold-review and rdd-completion-review reach through it, moves into the `modernpath` CLI as `modernpath audit citations` (ModernPath decision USER:2026-10-09:citation-audit-in-cli and :retire-audit-citations-mjs). A customer session on Windows had no Node.js to run the script, the skill copy installed under .claude/skills named a script that is not installed beside it, the script reported nearly every citation missing on Windows, and its elided-path pattern never matched. - rdd-audit's citation check names `modernpath audit citations`, with the same arguments, grammar, exit statuses and report. - rdd-audit states what to do when the audit cannot run: keep the error, read each citation the review relies on, and report the check as not run, never as passed; a reviewer without a shell gets the run, or the error, from the agent that runs it. - The coverage reference says "the citation audit it names" instead of the supplied script; its pinned wording is unchanged. - skills/rdd-audit/audit-citations.mjs and its test are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y what a not-run check means Fixes from the cold review of this pull request: - The check names the command the package's usual way, "In ModernPath, use `modernpath audit citations`", so the README's Distribution rule still holds and a reader without the ModernPath CLI gets a coherent instruction. - A run that printed no report did not run, whatever its exit status. A CLI without the command answers `unknown command "audit"` with exit 1, which read like a finding. `modernpath audit citations --help` exits 0 only when the command exists. - Exit 2 now lists every cause the command has: an unreadable document, missing Git and an invalid flag. - A citation check that did not run does not by itself block the gate the review serves. A run refused by its environment is a stop (PROCESS.md "Delegated passes"). - When a delegated pass cannot run commands, the orchestrating session hands it the command line, exit status, standard output and error, and each declared repository's revision. The pass lists the check as not run when that command line does not name the documents and repositories under review. - The checker's description includes backticked `path.ext:locator` citations, which it already resolves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
skills/rdd-audit/SKILL.mdmodernpath audit citations…". It replacesnode <skill-directory>/audit-citations.mjs …. The text keeps the script's contract: grammar, exemptions, resolution, report and exit statuses 0/1/2.2lists every cause the command has: a missing or unreadable target, an invalid inventory or missing Git, an invalid flag, or a refused prompt target.unknown command "audit"with exit 1.modernpath audit citations --helpexits 0 only when the command exists.Other files
skills/rdd-reverse-engineer/references/coverage.mdnow says "Userdd-auditand the citation audit it names" instead of "its suppliedaudit-citations.mjs".skills/rdd-audit/audit-citations.mjsandskills/rdd-audit/audit-citations.test.mjsare removed.Why
A customer's agent on Windows could not run the citation audit during a cold review. The script needs Node.js, which the CLI neither ships nor checks. Planning found more faults in the same script:
ModernPath decided (
USER:2026-10-09:citation-audit-in-cli,USER:2026-10-09:retire-audit-citations-mjs) that the CLI runs the audit and that the script is retired. The command is built in ModernPath/modernpath-v1#873.Tool naming
The README's Distribution rule says the distribution tool names the sanctioned tool. The skill follows it in the form other package skills use (
USER:2026-10-13:in-modernpath-form): it states the checker's contract and names the ModernPath command as ModernPath's instance. A consumer without the ModernPath CLI needs an equivalent checker for that contract. Until it has one, the not-run rule applies.Cold review
An independent cold review found nothing blocking and four should-fix items. The second commit fixes the text items: the old-CLI case, what the pass is handed, the tool naming, the exit-2 list and the wording. The merge-method item is answered below.
The review also asked whether a check that did not run blocks a gate. Decided (
USER:2026-10-13:not-run-check-does-not-block): it does not by itself; the review records it as not run and the human sees that at the gate.Merge — merge commit, then #873
main.mainnever names a command that no CLI on itsmainhas.Merging is the maintainer's decision.
🤖 Generated with Claude Code